From patchwork Tue Feb 25 16:41:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanislaw Gruszka X-Patchwork-Id: 22864 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 62817BDB1C for ; Tue, 25 Feb 2025 16:41:34 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7AC476871F; Tue, 25 Feb 2025 17:41:33 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="HAkNTRQN"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CCEB4686D6 for ; Tue, 25 Feb 2025 17:41:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740501691; x=1772037691; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=+0TiGhdKBZmHLDROsWk5daRW6d5aH1CaBveQK4Ng9n4=; b=HAkNTRQNVKW3OAN0xwQIIB619MlcnaO7XqKcOY5jHV9gINssMLaNMLkn /aUDntTsmnvB2SkrGJ+pDGXaJKa+B68kniVkWs8446lvKH7iY3fQio30Z su35vr/QCwHZJCit7OBCksbVtpzDoaBk5/RVeFconyCMAxlzCceBtE8XE 3Z/wZSGkZ6pIjrRzvpiEH72kHrMlnVJYMcz6swm9WHoR+z0CTcEDX9C2c EE/+G6vNeTqAsUiXeGrVcHbuQWye75BRPJck0OLunJfw1jAQLeHScWlto wCRsgmKVjWLgXJcU52381yr9Z7lw2etgtnjFEAmvMqDwutoKcv9iCbIJS w==; X-CSE-ConnectionGUID: AUCOoJzcSIWsOu3bGMuUdw== X-CSE-MsgGUID: PXYayN9GRmO11jiCEbKs7w== X-IronPort-AV: E=McAfee;i="6700,10204,11356"; a="51948199" X-IronPort-AV: E=Sophos;i="6.13,314,1732608000"; d="scan'208";a="51948199" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2025 08:41:29 -0800 X-CSE-ConnectionGUID: LbmXNo/BQXG/KIB/CxbVFQ== X-CSE-MsgGUID: DtR1BxUhSCChJ+AQTpQ2WA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,314,1732608000"; d="scan'208";a="117050535" Received: from sgruszka-mobl.ger.corp.intel.com (HELO localhost) ([10.245.115.185]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2025 08:41:27 -0800 From: Stanislaw Gruszka To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Laurent Pinchart , Kieran Bingham , Naushir Patuck , Sakari Ailus , Hans de Goede Subject: [PATCH v5 0/5] libcamera: start frame events changes Date: Tue, 25 Feb 2025 17:41:11 +0100 Message-Id: <20250225164116.414301-1-stanislaw.gruszka@linux.intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" v4 -> v5: - split patch2 into 3 separte patches - drop frameStartEnabled(), return error from start - use for (const Entity &entity : entities_) insted of iterator - reset delayed controls before enabling events - drop R-b , T-b tags since code changes substantially since got them v3 -> v4: - constify frameStartEnabled() - make supportsFrameStartEvent() more readable - rename eventEmitter to startFrameEmitter - update patch2 changelog to make it more clear v2 -> v3: - add helpers for v4l2_device - initialize eventEmitter_ in init(), when no proper device is found use nullptr (this fix crash seen by Kieran as eventEmitetter was not nullptr in v2) v1 -> v2: - make eventEmitter_ subdevice part of SimpleCameraData - add debug log when found event emitter device - nullify eventEmitter_ on stop - remove direct sensor_->setControls() - add delayedCtrls_->reset() on start Laurent Pinchart (1): pipeline: simple: Create DelayedControls instance once only Stanislaw Gruszka (4): libcamera: v4l2_device: add frame start event helpers pipeline: simple: Use proper device for frame start events pipeline: simple: Connect and disconnect start frame events pipeline: simple: Do not apply controls twice include/libcamera/internal/v4l2_device.h | 1 + src/libcamera/pipeline/simple/simple.cpp | 58 ++++++++++++++++++------ src/libcamera/v4l2_device.cpp | 19 ++++++++ 3 files changed, 65 insertions(+), 13 deletions(-) --- 2.43.0