From patchwork Fri Feb 21 11:26:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanislaw Gruszka X-Patchwork-Id: 22818 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1F3E0BEFBE for ; Fri, 21 Feb 2025 11:26:20 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1491C686A1; Fri, 21 Feb 2025 12:26:19 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="JCOmwehA"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B551A61857 for ; Fri, 21 Feb 2025 12:26:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740137177; x=1771673177; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=0zNfXdlVKXwFohB/ecy0tHQfHMOcARvv0EvRcrdzRB8=; b=JCOmwehA7kaXAxvZWNYUxqMioGx/cMhZyEc4pbwrBxdPr99DLi6d40Jl DUqmAb6cSZg1oWmN0cLUmY3gF7xROjTVe6bXDtS9i/KsUg8bmiEV/bO8y vDhYkk+bzt65zLkcZkEeZwkjcm9ICd1I1O1cg0iCU7KbUiqiR8lEyWwHx zP6WXLqAk1y9UlDdFhyOwWrfEdkFdzZlTySONs3eXv49V3bWPcdm45s7M svL5gGokbusaaxKHiaQ9Vx8A8z38ixAr0eJATDglmLzf2AyEpVhPiPfaY xIMokLvCEhGam8cZ8DKz4rXz5fuxd/2xq3vHqjDQS5a2OQ1YhPgAdWVMn g==; X-CSE-ConnectionGUID: XL7b2fbcTpuVxcF1Mu7bUg== X-CSE-MsgGUID: 8X3ng/ScSRCzytKWUW9ZeA== X-IronPort-AV: E=McAfee;i="6700,10204,11351"; a="44738580" X-IronPort-AV: E=Sophos;i="6.13,304,1732608000"; d="scan'208";a="44738580" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 03:26:15 -0800 X-CSE-ConnectionGUID: +KMA9nGZRsu32uWcbGslQg== X-CSE-MsgGUID: VJ3cdiGLQxiPtAnqnXipew== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,304,1732608000"; d="scan'208";a="115990699" Received: from sgruszka-mobl.ger.corp.intel.com (HELO localhost) ([10.245.97.15]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 03:26:12 -0800 From: Stanislaw Gruszka To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Laurent Pinchart , Kieran Bingham , Naushir Patuck , Sakari Ailus , Hans de Goede Subject: [PATCH v4 0/2] libcamera: start frame events changes Date: Fri, 21 Feb 2025 12:26:08 +0100 Message-Id: <20250221112610.42402-1-stanislaw.gruszka@linux.intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Use proper device for start frame events in simple pipeline. v3 -> v4: - constify frameStartEnabled() - make supportsFrameStartEvent() more readable - rename eventEmitter to startFrameEmitter - update patch2 changelog to make it more clear v2 -> v3: - add helpers for v4l2_device - initialize eventEmitter_ in init(), when no proper device is found use nullptr (this fix crash seen by Kieran as eventEmitetter was not nullptr in v2) v1 -> v2: - make eventEmitter_ subdevice part of SimpleCameraData - add debug log when found event emitter device - nullify eventEmitter_ on stop - remove direct sensor_->setControls() - add delayedCtrls_->reset() on start Stanislaw Gruszka (2): libcamera: v4l2_device: add frame start event helpers pipeline: simple: Use proper device for frame start events include/libcamera/internal/v4l2_device.h | 2 ++ src/libcamera/pipeline/simple/simple.cpp | 40 +++++++++++++++++++++--- src/libcamera/v4l2_device.cpp | 25 +++++++++++++++ 3 files changed, 63 insertions(+), 4 deletions(-) --- 2.43.0