From patchwork Thu Jan 23 14:07:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Scally X-Patchwork-Id: 22634 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 63703BDE6B for ; Thu, 23 Jan 2025 14:07:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 724F26855B; Thu, 23 Jan 2025 15:07:47 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="bGrGXLlr"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D1E761878 for ; Thu, 23 Jan 2025 15:07:45 +0100 (CET) Received: from mail.ideasonboard.com (cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BDE6289A; Thu, 23 Jan 2025 15:06:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1737641201; bh=bC9ULQiz/qlkf83VYs2ziwvo7/0ltfsj901AxdQCJ+U=; h=From:To:Cc:Subject:Date:From; b=bGrGXLlr5jqyp0bBAckurmTHCvPgMEd6AZpg2ZwrQ5KL5bsDOPr8X9d+6+WIo2RvE YhO9jlrq8ww2M3vxhxOuE0Fho0NAJt1KvNg3zqVsuN+8HVLDAkfQlrNpGGn0q73G7u MDQXOip9v8AqPxKAV7EvRhVgMsA8ttXHoxap9D5c= From: Daniel Scally To: libcamera-devel@lists.libcamera.org Cc: Daniel Scally Subject: [PATCH v2 0/3] Add flicker mitigation controls to AgcMeanLuminance Date: Thu, 23 Jan 2025 14:07:24 +0000 Message-Id: <20250123140727.458567-1-dan.scally@ideasonboard.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello all This short series adds flicker mitigation controls to each IPA that derives its AGC algorithm from AgcMeanLuminance. The mitigation works by adding AeFlickerMode and AeFlickerPeriod controls to AgcMeanLuminance - with the mode set to FlickerManual exposure time is capped at a multiple of AeFlickerPeriod, with the reduction in exposure time offset by increases to analogue and digital gain. The first patch is purely to make patch #3 slightly tidier; we have to add the new function call to the algorithms queueRequest() function in the same commit as introducing the new controls or we end up with a commit where the IPAs are advertising a control they don't actually support. Thanks Dan Daniel Scally (3): ipa: ipu3: Add skeleton Agc::queueRequest() function ipa: libipa: Adjust for flicker in ExposureModeHelper ipa: libipa: Add flicker controls to AgcMeanLuminance src/ipa/ipu3/algorithms/agc.cpp | 11 ++++++ src/ipa/ipu3/algorithms/agc.h | 3 ++ src/ipa/libipa/agc_mean_luminance.cpp | 48 ++++++++++++++++++++++++- src/ipa/libipa/agc_mean_luminance.h | 5 +++ src/ipa/libipa/exposure_mode_helper.cpp | 37 ++++++++++++++++--- src/ipa/libipa/exposure_mode_helper.h | 6 +++- src/ipa/mali-c55/algorithms/agc.cpp | 2 ++ src/ipa/rkisp1/algorithms/agc.cpp | 2 ++ 8 files changed, 108 insertions(+), 6 deletions(-)