From patchwork Fri Jan 10 23:57:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 22509 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D0A15C32DA for ; Fri, 10 Jan 2025 23:57:53 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0428C684E7; Sat, 11 Jan 2025 00:57:53 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ZHv88L3o"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 91B6060887 for ; Sat, 11 Jan 2025 00:57:50 +0100 (CET) Received: from pyrite.hamster-moth.ts.net (unknown [IPv6:2604:2d80:9e93:ad00:3d82:7e4f:ab9b:8a]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A058F886; Sat, 11 Jan 2025 00:56:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1736553415; bh=DHPiGP1e8sQi47H0FSE8f+1j/5hXjeM/baW9ondEPvY=; h=From:To:Cc:Subject:Date:From; b=ZHv88L3oelxAiRoInssIF/ph0n2tY2ws68iSM9nRWugiFmDrjnWtdi4TXiIOdBD28 s5kwxD/q99AvoTQxQLNfOyWYFSutz23kUO5Lrix2gMQfPllCUvJeLqkzoLTUilr8m7 mC5Z466UHG4jRTJXkuuFuCn06PBLFLQMlflMrFZg= From: Paul Elder To: libcamera-devel@lists.libcamera.org Cc: Paul Elder , laurent.pinchart@ideasonboard.com, stefan.klug@ideasonboard.com Subject: [PATCH v7 00/12] AEGC controls Date: Fri, 10 Jan 2025 17:57:25 -0600 Message-Id: <20250110235737.1524733-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This patch series introduces a new set of AEGC controls that allow: - flicker avoidance when switching from auto to manual - shutter priority / gain priority To achieve this, we remove the existing AeEnable control and add two separate controls that control enabling/disabling auto-exposure and auto-gain. The definition of AeState is also made more concrete. The first two patches add the new controls, as well as documentation and design rationale. The rest of the patches naturally update the existing users of AeEnable, before finally removing the control altogether. v4 mainly improves documentation and implements the proper behavior when transitioning between auto and manual modes for the rkisp1. v5 is mostly minor wording changes, plus a fix to the rkisp1 aegc implementation to support mixed manual-auto ae modes (aka "shutter priority" / "gain priority"). v6 notably re-introduces the AeEnable control, as it was deemed necessary (see the relevant patches for details). Instead of re-writing the previous patches, it is tacked on in the last 4 patches of the series (with a trivial modification to the 8th patch). v7 is mainly minor wording changes. Thanks, Paul Jacopo Mondi (4): libcamera: uvcvideo: Register ExposureTimeMode control test: ipa_data_serialization: Use DebugMetadataEnable ipa: raspberry: Port to the new AEGC controls controls: Remove AeLocked Paul Elder (8): controls: Introduce AEGC-related controls Documentation: design: ae: Document the design for AE controls ipa: rkisp1: Port to the new AEGC controls gstreamer: Generate the new AEGC controls controls: Redefine AeEnable libcamera: camera: Pre-process AeEnable control ipa: rkisp1: agc: Report new AeEnable control as available ipa: raspberry: Report new AeEnable control as available Documentation/design/ae.rst | 331 ++++++++++++++++++ Documentation/index.rst | 4 +- Documentation/meson.build | 1 + src/ipa/rkisp1/algorithms/agc.cpp | 131 +++++-- src/ipa/rkisp1/ipa_context.cpp | 24 +- src/ipa/rkisp1/ipa_context.h | 8 +- src/ipa/rpi/common/ipa_base.cpp | 74 +++- src/ipa/rpi/controller/agc_algorithm.h | 8 +- src/ipa/rpi/controller/rpi/agc.cpp | 52 ++- src/ipa/rpi/controller/rpi/agc.h | 8 +- src/ipa/rpi/controller/rpi/agc_channel.cpp | 24 +- src/ipa/rpi/controller/rpi/agc_channel.h | 8 +- src/libcamera/camera.cpp | 20 ++ src/libcamera/control_ids_core.yaml | 279 +++++++++++++-- src/libcamera/control_ids_draft.yaml | 30 -- src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 53 ++- .../ipa_data_serializer_test.cpp | 2 +- utils/codegen/gen-gst-controls.py | 5 +- 18 files changed, 941 insertions(+), 121 deletions(-) create mode 100644 Documentation/design/ae.rst