From patchwork Mon Oct 28 02:22:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 2249 Return-Path: Received: from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net [195.74.38.227]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 844836017C for ; Mon, 28 Oct 2019 03:22:42 +0100 (CET) X-Halon-ID: cb9d1881-f929-11e9-903a-005056917f90 Authorized-sender: niklas@soderlund.pp.se Received: from localhost.localdomain (unknown [93.2.121.143]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA id cb9d1881-f929-11e9-903a-005056917f90; Mon, 28 Oct 2019 03:22:38 +0100 (CET) From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: libcamera-devel@lists.libcamera.org Date: Mon, 28 Oct 2019 03:22:14 +0100 Message-Id: <20191028022224.795355-1-niklas.soderlund@ragnatech.se> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 00/10] libcamera: Fixes found while working on new buffer API X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Oct 2019 02:22:43 -0000 Hi, This series is a random collection of small fixes I encountered while working on the new buffer API. They could hopefully be merged without much controversy opposed to the real buffer API change. Niklas Söderlund (10): libcamera: buffer: Drop forward declaration of BufferPool libcamera: buffer: Plane: Drop friend statement libcamera: buffer: Drop friend statment libcamera: camera: Remove explicit stream to buffer map in requestCompleted signal cam: BufferWriter: Use the libcamera namespace libcamera: v4l2_videodevice: Simplify error checking for requestBuffers() libcamera: pipeline_handler: Do not use argument as local variable libcamera: pipelines: Align where to call base class queueRequest() cam: Store camera as shared pointer everywhere libcamera: pipeline: Drop forward declaration of BufferPool include/libcamera/buffer.h | 4 --- include/libcamera/camera.h | 2 +- src/cam/buffer_writer.cpp | 8 +++--- src/cam/capture.cpp | 6 +++-- src/cam/capture.h | 7 +++--- src/cam/main.cpp | 2 +- src/libcamera/camera.cpp | 2 +- src/libcamera/include/pipeline_handler.h | 1 - src/libcamera/pipeline/ipu3/ipu3.cpp | 5 ++-- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 +-- src/libcamera/pipeline/uvcvideo.cpp | 4 +-- src/libcamera/pipeline/vimc.cpp | 4 +-- src/libcamera/pipeline_handler.cpp | 8 +++--- src/libcamera/v4l2_videodevice.cpp | 31 ++++++++---------------- src/qcam/main_window.cpp | 5 ++-- src/qcam/main_window.h | 3 +-- test/camera/capture.cpp | 4 ++- 17 files changed, 42 insertions(+), 58 deletions(-) Reviewed-by: Jacopo Mondi Reviewed-by: Kieran Bingham