From patchwork Thu Dec 5 11:22:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 22172 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 24ED2C323E for ; Thu, 5 Dec 2024 11:22:53 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 56B8E660EA; Thu, 5 Dec 2024 12:22:52 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="L2X/v9iV"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F1B96608C for ; Thu, 5 Dec 2024 12:22:51 +0100 (CET) Received: from neptunite.flets-east.jp (unknown [IPv6:2404:7a81:160:2100:9fc8:318e:a239:9653]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CC0852B3; Thu, 5 Dec 2024 12:22:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1733397742; bh=de91ZqBOrZaAmL3w7PRteNGBABx8QMoQE5ankhFPpvw=; h=From:To:Cc:Subject:Date:From; b=L2X/v9iVRuQXlRXDw9ViOsXwZOGH3vVUX5yZDfcTlLbD2Of0QVs5w9ugsVmSHw4wx UE+AFbcihKmPjs7s7UZ98X24ACrsbeN46/fescQPJoQdbLTocgoUgZ6fSzchZfe8Bc tcTCpkb6sXLcn1RsX7mBi5QUcEagVS3uwn6FSj+U= From: Paul Elder To: libcamera-devel@lists.libcamera.org Cc: Paul Elder Subject: [PATCH v4 0/8] AEGC controls Date: Thu, 5 Dec 2024 20:22:33 +0900 Message-Id: <20241205112241.641964-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This patch series introduces a new set of AEGC controls that allow: - flicker avoidance when switching from auto to manual - shutter priority / gain priority To achieve this, we remove the existing AeEnable control and add two separate controls that control enabling/disabling auto-exposure and auto-gain. The definition of AeState is also made more concrete. The first two patches add the new controls, as well as documentation and design rationale. The rest of the patches naturally update the existing users of AeEnable, before finally removing the control altogether. v4 mainly improves documentation and implements the proper behavior when transitioning between auto and manual modes for the rkisp1. Thanks, Paul Jacopo Mondi (4): libcamera: uvcvideo: Register ExposureTimeMode control test: ipa_data_serialization: Use DebugMetadataEnable ipa: raspberry: Port to the new AEGC controls controls: Remove AeEnable and AeLocked Paul Elder (4): controls: Introduce AEGC-related controls Documentation: design: ae: Document the design for AE controls ipa: rkisp1: Port to the new AEGC controls gstreamer: Generate the new AEGC controls Documentation/design/ae.rst | 320 ++++++++++++++++++ Documentation/index.rst | 4 +- Documentation/meson.build | 1 + src/ipa/rkisp1/algorithms/agc.cpp | 102 +++++- src/ipa/rkisp1/ipa_context.cpp | 22 +- src/ipa/rkisp1/ipa_context.h | 8 +- src/ipa/rpi/common/ipa_base.cpp | 74 +++- src/ipa/rpi/controller/agc_algorithm.h | 8 +- src/ipa/rpi/controller/rpi/agc.cpp | 52 ++- src/ipa/rpi/controller/rpi/agc.h | 8 +- src/ipa/rpi/controller/rpi/agc_channel.cpp | 24 +- src/ipa/rpi/controller/rpi/agc_channel.h | 8 +- src/libcamera/control_ids_core.yaml | 286 +++++++++++++--- src/libcamera/control_ids_draft.yaml | 29 -- src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 54 ++- .../ipa_data_serializer_test.cpp | 2 +- utils/codegen/gen-gst-controls.py | 5 +- 17 files changed, 885 insertions(+), 122 deletions(-) create mode 100644 Documentation/design/ae.rst