From patchwork Tue Dec 3 09:38:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Milan Zamazal X-Patchwork-Id: 22153 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 30779BDC71 for ; Tue, 3 Dec 2024 09:38:28 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0C60D6607B; Tue, 3 Dec 2024 10:38:26 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="T0ygqhqB"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C33A9618B1 for ; Tue, 3 Dec 2024 10:38:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733218703; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fODcXQprng+YHxWY3SJnDvGcmcgYyAQDSu7TpdX6FC4=; b=T0ygqhqBCslrPW/RhyzhHKBdm4QDp4pa1/RkMOx43hHbBqxZRKRVL5cOa8XC7hI5/l7e9g 7m98AYVkttn4shpnR7XNRbH7XMZYnd5R8MrDt2pfGZzkED5WkqIVp/PuUHyp5ih06kah4d Fs18oIqRePqsxPcAQGYcKrqVQdWz5Hg= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-487-ZY7_NEpKPnSVKAgWM8wZbA-1; Tue, 03 Dec 2024 04:38:20 -0500 X-MC-Unique: ZY7_NEpKPnSVKAgWM8wZbA-1 X-Mimecast-MFC-AGG-ID: ZY7_NEpKPnSVKAgWM8wZbA Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 16B051955F45; Tue, 3 Dec 2024 09:38:19 +0000 (UTC) Received: from nuthatch.brq.redhat.com (unknown [10.43.17.31]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A2E5E30000DF; Tue, 3 Dec 2024 09:38:17 +0000 (UTC) From: Milan Zamazal To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Kieran Bingham , Robert Mader Subject: [PATCH v2 0/1] libcamera: software_isp: Actually apply black level from tuning data Date: Tue, 3 Dec 2024 10:38:12 +0100 Message-ID: <20241203093814.67984-1-mzamazal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xxV8aNbN2GwxjzeAphVpGagfycyNi0SOo6Gj4NhHLjc_1733218699 X-Mimecast-Originator: redhat.com X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This is an alternative proposal fixing the black level to https://patchwork.libcamera.org/patch/21703/ by Robert. This patch fixes just the obvious bug, the other parts of the given series, i.e. attempt to fix problems when switching cameras[1] or introducing IMX355 helper, are not covered. This patch can be handled separately or incorporated into the Robert’s series or another solution may be proposed. [1] I wonder whether https://patchwork.libcamera.org/project/libcamera/list/?series=4752 could be related. Changes in v2: - Rebased on master. Milan Zamazal (1): libcamera: software_isp: Actually apply black level from tuning data src/ipa/simple/algorithms/blc.cpp | 7 +++++-- src/ipa/simple/algorithms/blc.h | 4 ++++ src/ipa/simple/soft_simple.cpp | 3 +-- 3 files changed, 10 insertions(+), 4 deletions(-)