From patchwork Fri Nov 29 18:53:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cheng-Hao Yang X-Patchwork-Id: 22143 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 787F8C31E9 for ; Fri, 29 Nov 2024 18:55:45 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 90F4B6603B; Fri, 29 Nov 2024 19:55:44 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="m9EL1Rrm"; dkim-atps=neutral Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id EB8806601A for ; Fri, 29 Nov 2024 19:55:41 +0100 (CET) Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-2124a86f4cbso17388545ad.3 for ; Fri, 29 Nov 2024 10:55:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1732906539; x=1733511339; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=RaLpaB6HRPdWhsF6wqO6uIPh15hpoo4OAuhFy/V6cIY=; b=m9EL1Rrm2ZwZVF4RTlstECb3Kp1zFA5kLEjtUrixK60fIOPgI6Nkva1/gsfrX6VpBT 2fSDFCmTU8KRYqJ+AfwqJ+C7Rd6VR+I/JQdtUv7QFYFU5/Mw9nv2ftM4rWxO1hSrMCEf v0bx6xtp2rST2tLEtbfYHgz62qaEHwpp6mlYY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732906539; x=1733511339; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RaLpaB6HRPdWhsF6wqO6uIPh15hpoo4OAuhFy/V6cIY=; b=OChDcTSxSEITj9sDuD65u5Wv8NclE12sSq6Xp1EsDNlHnE9gwBdlaeTXgVdoRaw0AF gTU/qzWWq3cyNl2GxJi7XingL9qrxB9NPw3Noko3KHcfFXrECU6Bo8gU4oY246suDyVy GXtqTrpBTF4DjUkBh4WvqNuWbw/u//a7Iu6ZtUWVlsu8D4jLzULzBJhx0cBbfIpSuav2 +DgcPw8p1dgoVvSuRm88t1COqZ6Cstop0FdUm1tz+mcmHllkBEUnFNRMWqSNBxocU8EB 0XauK8FWb7/tZt8xY26wxDeOfsyBOlLesNOpOXLky37KQb79KJwXodytCo82XGjJToC5 BTxQ== X-Gm-Message-State: AOJu0YwsIy1Ja046M8XMD2BFZjoYd/rBT8CZjm4O4Zgxmybtz2OHmwD/ X9I4R7LH+Hb/BbVoadVz5YAt18ATOR+kTKF6LGveZ7ClzgMXaxoV68/7SP+EWUZrDdiyHByDjFI = X-Gm-Gg: ASbGncvTJ/IKcWGpyxaZmj+7fP1DC42s0yh4as5uGVmTNN+kv1v8QPE9cxfY4byH+5Z /Xysoov78lhi7rj8PTTeWSNS1o1Ve7z+4RIDcZbxzbZ0kj8sk3uoPK1Q05eScgbv+2QSodZJKHB SL4HAM8ILrKVY4GVorAqEEWO2CQMT/RO1eFluQ0RSn6Wf33ct0ponDa/3kVMriCMfcvBPi2KCEv 1YxGVexnfBAjNFARpzh69ElMe5zeeVDC43FuMjruV8xicUk60PbImAO69bBamnXeE8ZWavGRcKD OrY+byYymiIoa4/G79QZ5AYA79swk9+t4N3Q/IdQfd9aIoYsmDd4pnXf X-Google-Smtp-Source: AGHT+IFepXOlGO5D+185zWgN/sbA5S71h27G6Kxwu/Mc4pUwdTORpvOs0fWa/7ySnVe4NLJFi5kDcg== X-Received: by 2002:a17:902:c945:b0:20c:f0dd:c408 with SMTP id d9443c01a7336-2150109b04bmr122568905ad.20.1732906539449; Fri, 29 Nov 2024 10:55:39 -0800 (PST) Received: from chenghaoyang-low.c.googlers.com.com (112.212.229.35.bc.googleusercontent.com. [35.229.212.112]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21546470f46sm13661995ad.105.2024.11.29.10.55.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Nov 2024 10:55:39 -0800 (PST) From: Harvey Yang To: libcamera-devel@lists.libcamera.org Cc: Harvey Yang Subject: [PATCH 0/1] Make DmaSyncer non-copyable Date: Fri, 29 Nov 2024 18:53:27 +0000 Message-ID: <20241129185533.3308449-1-chenghaoyang@chromium.org> X-Mailer: git-send-email 2.47.0.338.g60cca15819-goog MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi folks, Thanks to Laurent's comment, I prepare the fix to make DmaSyncer non-copyable. Note that I have to add the move c'tor & operator= to use DmaSyncer in std::vector. Please check if it makes sense. The patch passes gitlab pipeline: https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1320271 Please take a look. Thanks! BR, Harvey Harvey Yang (1): DmaBufAllocator: Make DmaSyncer non-copyable include/libcamera/internal/dma_buf_allocator.h | 5 +++++ src/libcamera/dma_buf_allocator.cpp | 10 ++++++++++ 2 files changed, 15 insertions(+)