From patchwork Fri Nov 22 20:13:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Milan Zamazal X-Patchwork-Id: 22057 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 2E3F0C32FE for ; Fri, 22 Nov 2024 20:13:20 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5DC4B65FE5; Fri, 22 Nov 2024 21:13:19 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="R5LpzsIW"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 672BA65F51 for ; Fri, 22 Nov 2024 21:13:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732306396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Xoail1WNFs5SKM/8c2b5sTr1+cyhWCBnbvfVq6+9VC0=; b=R5LpzsIW4hhML4N+HGQN898MqMHw8u95ezhXQKB0Dz83fSqgwIRmVl5WuMU8jH+HjM+00E /TrpdWLsCDls+tprGBwLyyfQPBZjDTiWrtlvyGRoj6ZU3rTxghku2dYfrSB+UoIzYdU/gK 5gUUMHJiqovVJX/QyA5ID778brJLD0I= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-272-TFtgx-3-OiewlGMlSHOkkw-1; Fri, 22 Nov 2024 15:13:12 -0500 X-MC-Unique: TFtgx-3-OiewlGMlSHOkkw-1 X-Mimecast-MFC-AGG-ID: TFtgx-3-OiewlGMlSHOkkw Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6A27219560BD; Fri, 22 Nov 2024 20:13:11 +0000 (UTC) Received: from nuthatch.redhat.com (unknown [10.45.224.2]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C23F21956086; Fri, 22 Nov 2024 20:13:09 +0000 (UTC) From: Milan Zamazal To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , bryan.odonoghue@linaro.org Subject: [RFC PATCH 0/1] Enable raw streams with software ISP Date: Fri, 22 Nov 2024 21:13:03 +0100 Message-ID: <20241122201305.1668098-1-mzamazal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gqMMR3P6t53GLVWB8AW6HDGX4FBxP84pRgW3In7tSGU_1732306391 X-Mimecast-Originator: redhat.com X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This makes raw streams working again in ‘simple’ pipeline when software ISP is enabled for the given device. For now, only a single raw stream is supported and there are no immediate plans to change that unless there is a request for more. An example ‘cam’ invocation requesting a raw stream rather than a debayered stream: cam -c1 -C8 -s role=raw,width=1920,height=1080 -Ffile#.raw See the commit message for more information about the patch. The patch is RFC because I’m not sure where it is placed on the scale between a hack/PoC and a proper solution and because it’s not that useful until a control for exposure/gain adjustments is implemented. In the meantime, fixed exposure+gain can be hardwired in src/ipa/simple/soft_simple.cpp by changing the lines ctrls.set(V4L2_CID_EXPOSURE, …); ctrls.set(V4L2_CID_ANALOGUE_GAIN, …); to set the desired values (values used under the given conditions can be obtained from normal software ISP debayered output debug log). Milan Zamazal (1): libcamera: simple: Fix raw output src/libcamera/pipeline/simple/simple.cpp | 66 +++++++++++++++++++----- 1 file changed, 54 insertions(+), 12 deletions(-)