From patchwork Mon Nov 18 15:05:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 21955 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B2C5BC32DD for ; Mon, 18 Nov 2024 15:05:45 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id EB25B658E2; Mon, 18 Nov 2024 16:05:44 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="JPTo17fc"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D1CE760532 for ; Mon, 18 Nov 2024 16:05:42 +0100 (CET) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:4424:4869:bb88:5c61]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F265F316; Mon, 18 Nov 2024 16:05:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1731942326; bh=K8hRoKT1mLqyoO+pBpbTzIaaNuAt0tHXYVs/wrfM+/E=; h=From:To:Cc:Subject:Date:From; b=JPTo17fcDxmp1Bn7zksx6ly6fPMiLB+w0kdzwww0yw3SZ9bZ9pMviaUE+SahcnSzI nrGH52jrw5WxKLm3VgvMt9cHw404xQ3XBovzKSSxl1RwcGZK1SiZciSvWAPqJgl/6P TPAI64QT5+9YBpiNqC6mn0J4f3R4+hXHxiG32gds= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH 0/4] Move Matrix class from libipa to libcamera Date: Mon, 18 Nov 2024 16:05:03 +0100 Message-ID: <20241118150528.1856797-1-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi all, My upcoming dewarper series implements parametric lens dewarping inside the rkisp1 pipeline. That code makes use of the Matrix class but lives outside of the IPA. I suspect there will be more cases, where a matrix is of good use inside libcamera. This series movies the Matrix into libacmera/internal. As that gets linked to the IPAs anyways, there are no negative effects for the IPAs. This was tested on an imx8mp, but only compile tested for the RaspberryPi. Regards, Stefan Stefan Klug (4): libcamera: Copy matrix class from libipa to libcamera libcamera: Enable and use matrix implementation from libcamera/internal libcamera: matrix: Use Span instead of vector for construction libipa: Remove Matrix class from libipa .../libcamera/internal}/matrix.h | 23 ++++---- include/libcamera/internal/meson.build | 1 + src/ipa/libipa/meson.build | 2 - src/ipa/libipa/vector.h | 3 +- src/ipa/rkisp1/algorithms/ccm.h | 3 +- src/ipa/rkisp1/ipa_context.h | 2 +- src/ipa/rpi/controller/rpi/ccm.cpp | 56 +++++-------------- src/ipa/rpi/controller/rpi/ccm.h | 35 +----------- src/{ipa/libipa => libcamera}/matrix.cpp | 18 ++++-- src/libcamera/meson.build | 1 + 10 files changed, 48 insertions(+), 96 deletions(-) rename {src/ipa/libipa => include/libcamera/internal}/matrix.h (89%) rename src/{ipa/libipa => libcamera}/matrix.cpp (89%)