From patchwork Fri Nov 8 09:43:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Milan Zamazal X-Patchwork-Id: 21864 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 406F3BE173 for ; Fri, 8 Nov 2024 09:43:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3E54765499; Fri, 8 Nov 2024 10:43:47 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="HwAtzk8f"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A942660589 for ; Fri, 8 Nov 2024 10:43:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731059024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pbJS8y3k1pp092aQo+tQyt/RCsPdM4OHZ+OMZ5Cc+UE=; b=HwAtzk8fkhjtWdB+JfHYzHnobq+dd++pqX3+vD2eECEifElXisDcDRhEwjSb1rRy0aQuTP mym5euqF/0JjtBvT5CTO6W66vpTme/5ncBsD+4f018WT8IETz6HapQhhwzBj161oPNBu8o 6AY6zfRn6DmC3AQiu05/PYt0SODY8f0= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-160-K4yJrsmpOASd_fO7IxQvoA-1; Fri, 08 Nov 2024 04:43:41 -0500 X-MC-Unique: K4yJrsmpOASd_fO7IxQvoA-1 X-Mimecast-MFC-AGG-ID: K4yJrsmpOASd_fO7IxQvoA Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5554B1955E95; Fri, 8 Nov 2024 09:43:40 +0000 (UTC) Received: from nuthatch.redhat.com (unknown [10.45.225.119]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E32851955F3D; Fri, 8 Nov 2024 09:43:38 +0000 (UTC) From: Milan Zamazal To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Robert Mader Subject: [PATCH 0/1] libcamera: software_isp: Actually apply black level from tuning data Date: Fri, 8 Nov 2024 10:43:30 +0100 Message-ID: <20241108094333.332643-1-mzamazal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zIOujyl91Yvj2ZCZOqC3zeYGz4h0-FiKfkBGHxhLUBY_1731059020 X-Mimecast-Originator: redhat.com X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This is an alternative proposal fixing the black level to https://patchwork.libcamera.org/patch/21703/ by Robert. This patch fixes just the obvious bug, the other parts of the given series, i.e. attempt to fix problems when switching cameras[1] or introducing IMX355 helper, are not covered. This patch can be handled separately or incorporated into the Robert’s series or another solution may be proposed. [1] I wonder whether https://patchwork.libcamera.org/project/libcamera/list/?series=4752 could be related. Milan Zamazal (1): libcamera: software_isp: Actually apply black level from tuning data src/ipa/simple/algorithms/blc.cpp | 7 +++++-- src/ipa/simple/algorithms/blc.h | 4 ++++ src/ipa/simple/soft_simple.cpp | 3 +-- 3 files changed, 10 insertions(+), 4 deletions(-)