From patchwork Tue Nov 5 10:49:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harvey Yang X-Patchwork-Id: 21812 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5B99EBDB1C for ; Tue, 5 Nov 2024 10:54:53 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8BF86653F1; Tue, 5 Nov 2024 11:54:52 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="ZjWXcQcO"; dkim-atps=neutral Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 589A36035B for ; Tue, 5 Nov 2024 11:54:51 +0100 (CET) Received: by mail-oi1-x234.google.com with SMTP id 5614622812f47-3e60825aa26so2742483b6e.1 for ; Tue, 05 Nov 2024 02:54:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730804090; x=1731408890; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yt/MxP9JqRZz67Jfii/ave7jD09W4W/Jo9pu9HGiVP8=; b=ZjWXcQcOfunM7U8WXGVoDaF++wuO5H4A/xjRtTbvVXzY16Gy/blbyF5GnTZbTf0usv 2WVdOL9wE+ORrEoFOSfXJBJAtpfaeEOR2D+dL0XnanE7qHCIYXxknEBGjPS4LbttNKhw UbV0AkthkMbdO/C3uD5Ec6u2tV71EEJOR5gqQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730804090; x=1731408890; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yt/MxP9JqRZz67Jfii/ave7jD09W4W/Jo9pu9HGiVP8=; b=VXUQ5Ay3MU7RcBg9gP1XFPaOE/BHEReILhxGyjAAbN/snpIE2C/QUS3jzPZwe/xLt0 ERBZtXw0bsIBQuH1icyj3gEGNu6auvIxs25R2cgfSKzdgZpTvKFayIGP2ZhVkEZR/Dj7 PZZopPXo/G8mNaE7kMuaQ8yCuI9dwnUDowz12xq88id5ZG1R0S6pY/1MtmV/tUbZyQqe ryvsFNGvgDO1TbT4pcelvx+wqZpOIODmeZ+Qg6JRDKWuR0q+2bzovs+jtwel9w/pnAiF 5Wud/oW/lEvynbIHvwSro299E6IVPn1Z7GAiqnY5Wk33qZxB/dZxtJwQMU2QVFab2Ax1 cWsA== X-Gm-Message-State: AOJu0Yyg2W0pz/zZDRRYoss/9BCqkFADjv89oBlOaA21cgbJ4j4Qp+f8 472CWQdZnfU2mj9vo+FzQeAvCtvfVayER9VeyNafvrYat4e9kSps+TBcs3ZRdf9mNpOGxUrxFk0 = X-Google-Smtp-Source: AGHT+IGT/KMr2/Trjbxa3DID9frNTgew87jWf5m16QOCN1xoH+3wld5bAe/CcBcblxQElj67M2Yj3A== X-Received: by 2002:a05:6808:330a:b0:3e6:402:d228 with SMTP id 5614622812f47-3e758c17adamr13317031b6e.13.1730804089778; Tue, 05 Nov 2024 02:54:49 -0800 (PST) Received: from chenghaoyang-low.c.googlers.com.com (27.247.221.35.bc.googleusercontent.com. [35.221.247.27]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7ee45a002d4sm8817612a12.70.2024.11.05.02.54.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2024 02:54:49 -0800 (PST) From: Harvey Yang To: libcamera-devel@lists.libcamera.org Cc: Harvey Yang Subject: [PATCH 0/1] Add v4l2_subdev_format in V4L2SubdeviceFormat Date: Tue, 5 Nov 2024 10:49:20 +0000 Message-ID: <20241105105445.1468954-1-chenghaoyang@chromium.org> X-Mailer: git-send-email 2.47.0.199.ga7371fff76-goog MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi folks, This patch adds extra information in V4L2SubdeviceFormat, which will be needed in mtkisp7: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/third_party/libcamera/mtkisp7/src/libcamera/pipeline/mtkisp7/camsys/camsys.cpp;l=371 I think we can also choose to just add the format (type: v4l2_mbus_framefmt) into the struct though. However, in either approach, we are duplicating the information with other existing member variables. Please check if this patch makes sense, or if there are other approaches. BR, Harvey Han-Lin Chen (1): libcamera: Add v4l2_subdev_format in V4L2SubdeviceFormat include/libcamera/internal/v4l2_subdevice.h | 2 ++ src/libcamera/pipeline/simple/simple.cpp | 2 +- src/libcamera/sensor/camera_sensor.cpp | 1 + src/libcamera/v4l2_subdevice.cpp | 10 ++++++++++ 4 files changed, 14 insertions(+), 1 deletion(-)