From patchwork Thu Oct 31 09:49:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 21781 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B0361C31E9 for ; Thu, 31 Oct 2024 09:52:45 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4A4BE653AC; Thu, 31 Oct 2024 10:52:44 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="lOa7JSEh"; dkim-atps=neutral Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 344ED618BF for ; Thu, 31 Oct 2024 10:52:42 +0100 (CET) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4315b957ae8so840025e9.1 for ; Thu, 31 Oct 2024 02:52:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1730368361; x=1730973161; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yguVaq99linEW/mz34LbN3fDEh7ICN2e264hc/htwYM=; b=lOa7JSEhLaVcjTWqsYWeR1jJpr6hzb5rS9O16BjVyo1B1xmb5TrMgwzSd1tWJ2yTVq QFtEZAiQoqoESa3XiMEkJdpWwy3wqfKTAbChSiZ7sltc4dQZQxF8fSTD3T70th5KWyOR 8EZvReGKvzJ4mMttuqwhyHfuAlZMZydMGs5J8/kS7tuVNrnoCi5fcpnzJkuwd8BffJVI M+8xovk730iSUsUclpHJ09o6YuXhO1zVAApp+b8gyJStfwnLphc+9mD03gJHorZQ4LoP n/LmqwP74XuMzYphvL4JKLTkR8sIVBbOI00640/4rmx3+YVHWNtrpoZlx96WEjfUQgJI Uj8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730368361; x=1730973161; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yguVaq99linEW/mz34LbN3fDEh7ICN2e264hc/htwYM=; b=aLBFhrBiz5kgK6tQcMWC77D0e6CrO+pu1DNJUvofS/lNAX8ju3EXezGy+n55WIiJUW G6Oe+2rqGn7VUTbME105tlKeYVPazTC3oYsOLgVudVC3Urk9SHnr0EpARZ6kZ0qxd0wo LhjiJSuSZrFUZMIPjMum0lgQCIeyOMj6UN5FKsu8SpXPEYUZKn4bDD6UubbAVawzMHJY 80fYO2jCea6fKqIZRcQD4zGWDx5aDcslm7G4Z8VMePm/nvpRMtqH0q95CuG98puo6CHR DkcpiT/uCKACaVTqpvGtTafIqrwRWxYjRFkeaCAU6NhagA8+WcuQEiBp3SssBXBBS1Xo EQmQ== X-Gm-Message-State: AOJu0YzrwMUicoURCqUbgiUk/O/NKUASHI2xTHNUo3NXcjpcQHXy4nmt P5LKCxBzigS4GV2MJdczycYASnbxkws3qcmCdC6PoA+8Vs+HaCiSNGpy1jVjFPKlZ70S+KZ5vNB x X-Google-Smtp-Source: AGHT+IHNzkTUsGUfQCFX+aBVhB9M6o4X4QFGgnTPLMv1uhu6nHpONOKd8wUebGEpBuuUVy1RnL4low== X-Received: by 2002:a05:600c:4fd4:b0:42c:b9c8:2b95 with SMTP id 5b1f17b1804b1-4319ad3ea89mr72810055e9.6.1730368361339; Thu, 31 Oct 2024 02:52:41 -0700 (PDT) Received: from naush-laptop.pitowers.org ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4327d6983c2sm19789835e9.42.2024.10.31.02.52.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 02:52:40 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Cc: Naushir Patuck Subject: [PATCH v4 0/7] Raspberry Pi: Add controls::rpi::ScalerCrops Date: Thu, 31 Oct 2024 09:49:50 +0000 Message-Id: <20241031094957.18471-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, No functional differenced in v7 compared to v6: - Fix commit message + code comments regarding priority of the controls. - Fix indentation of the control info for rpi::ScalerCrops. Regards, Naush Naushir Patuck (7): controls: rpi: Add a vendor rpi::ScalerCrops control pipeline: rpi: Remove CameraData::scalerCrop_ pipeline: rpi: Pass crop rectangle as a parameter to platformSetIspCrop() pipeline: rpi: Introduce CameraData::CropParams pipeline: rpi: Track which ISP output is configured for a stream pipeline: rpi: Pass ISP output index into platformSetIspCrop() pipeline: rpi: Handler controls::rpi::ScalerCrops src/ipa/rpi/common/ipa_base.cpp | 12 +++ src/libcamera/control_ids_rpi.yaml | 25 +++++ .../pipeline/rpi/common/pipeline_base.cpp | 95 +++++++++++++------ .../pipeline/rpi/common/pipeline_base.h | 22 ++++- src/libcamera/pipeline/rpi/vc4/vc4.cpp | 17 +++- 5 files changed, 135 insertions(+), 36 deletions(-)