From patchwork Tue Oct 29 16:07:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harvey Yang X-Patchwork-Id: 21770 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A0D62C31E9 for ; Tue, 29 Oct 2024 16:11:26 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9637E653A1; Tue, 29 Oct 2024 17:11:25 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="B5+M+pSN"; dkim-atps=neutral Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 68A2B60366 for ; Tue, 29 Oct 2024 17:11:23 +0100 (CET) Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-20cdda5cfb6so54515955ad.3 for ; Tue, 29 Oct 2024 09:11:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730218281; x=1730823081; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dNaxGuiFiAKTTEyHXGlPPleYPiMR3LGs9lpvgY66N1k=; b=B5+M+pSNBgQSKMdtoMvGLdSSn7rS33mpgNaYBD6RqCRjt1673nSMtkNWtLDuTVBEfB 9jYm22bofHv3ZXkQlVPgjqer0CgRH2rtyIPranCyO/YcNuS7HRLRHXlBg/TugWjv85gS tPgak7LVoeyVoy7iFiCazDIWRgqSQYJegdIHo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730218281; x=1730823081; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dNaxGuiFiAKTTEyHXGlPPleYPiMR3LGs9lpvgY66N1k=; b=Z/v6W6YTJ6t5hq1CnK8HOOidwEjgify77X2lHn5KT5pqcgv6QdmWjd3gYhNQqob92T 8kO8XXcaV7xb8ssnNBbBFLy4nNPNkgxj87rFljUqhpIxx3E4gRjScapjfTSOovN6oS2E C25EYE56/2etRZtYeFC1d9uf/EPTmuahuNtL+iwL30UyjJCjcaVLLHqF7SZ3E3e6+gD3 ffr4xYHC9YLHu9V0FHf0jssqCRfns4yd9PSSd9l2XMpU138HhFIioNN5kjMcldM/5Ilo 7xZcoKzTTeC3ZzgvzjEJNLRukX9W27821jgK6SxZk9jhofOjYaGT5uNgiNt8njw6zWWw vs8g== X-Gm-Message-State: AOJu0YxU9v4Dtt0eVUcCXyUhwVEryDEbdc/ioX3SDnArvQiy1DxvMEcb VItR3WQFKG6UaNaFv9tpCashnkmxShrzMtO7BDM9r1ufa4RJzMMx+lEV4QGSYU3jk4Bs75AD55Y = X-Google-Smtp-Source: AGHT+IFrd9LOxSh+GE3TNtvgESdUfo2+pMI22/05ymue1dp7XC9+4GXhxNqTjHTDnEdqfGZbCjFE0w== X-Received: by 2002:a17:903:41c2:b0:20b:54cc:b34e with SMTP id d9443c01a7336-210c6cff16bmr185855515ad.51.1730218281539; Tue, 29 Oct 2024 09:11:21 -0700 (PDT) Received: from chenghaoyang-low.c.googlers.com.com (199.211.81.34.bc.googleusercontent.com. [34.81.211.199]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bc04575esm68048695ad.235.2024.10.29.09.11.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2024 09:11:21 -0700 (PDT) From: Harvey Yang To: libcamera-devel@lists.libcamera.org Cc: Harvey Yang Subject: [PATCH v5 0/2] Add U16 & U32 support in controls Date: Tue, 29 Oct 2024 16:07:11 +0000 Message-ID: <20241029161117.1197603-1-chenghaoyang@chromium.org> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi folks, This series of patches adds Unsigned int 16 & 32 support in controls, which are needed for metadata & ext controls perspectively. This passes gitlab pipeline: https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1300098 Updates in v5: - Fixed setControls() and getControls() with new types supported. Updates in v4: - Added U32 & U16 entries in V4L2Device::getControls. Updates in v3: - Commit messages. - Added unit tests. Updates in v2: - Added default potential array `size = 0;`. - Removed unrelated debug message changes. BR, Harvey Yudhistira Erlandinata (2): libcamera: Extend u32 control type libcamera: Extend u16 control type include/libcamera/controls.h | 14 ++++++ src/libcamera/controls.cpp | 20 ++++++++- src/libcamera/v4l2_device.cpp | 67 ++++++++++++++++++++++++--- test/controls/control_value.cpp | 80 +++++++++++++++++++++++++++++++++ 4 files changed, 174 insertions(+), 7 deletions(-)