From patchwork Fri Oct 25 15:38:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harvey Yang X-Patchwork-Id: 21754 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8070BC3220 for ; Fri, 25 Oct 2024 15:39:58 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A235B6539A; Fri, 25 Oct 2024 17:39:57 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="fpA93q0T"; dkim-atps=neutral Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 50B896538B for ; Fri, 25 Oct 2024 17:39:55 +0200 (CEST) Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-2e3d523a24dso1683712a91.0 for ; Fri, 25 Oct 2024 08:39:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1729870793; x=1730475593; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Nk/v8MXs6PMr3pQCQzwUrrStg/WWWx4PrgR0X6kXKug=; b=fpA93q0TNJuHaQF2GxK5TEY9+CcC82HUCo8oOEzJJ/iQfyHqJfWBo8C48/AJnbiFHp LW8iC99t1hs3BrcoUIkgPfdZAF4oQPEDskYbUQBp83SErIfE5rI7iWOtya5HFogTnrnS /wjxoDA2/lxpCw9xPKS8Hu+xnUCbJBh8WTxLM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729870793; x=1730475593; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Nk/v8MXs6PMr3pQCQzwUrrStg/WWWx4PrgR0X6kXKug=; b=v06nUksS/efPUxfkDpbHIUtwDG+WtNQZVhH75x5VaaSRy8fTrPIBwVcghUdfTa6kNz +Phy7OyOEPIe4oxDrDmjn1X6pqWzLHTKgGX+LrjNgIcjQBX5c/KTMCWRdGj0Cl6cQyze vvS1RGnG3Ru8uWyzg1AGU7pVyk0t9ILa4AF+DxFETncl+w1c6zP7nwse7sm7+kEbaJ9N LJKqwbBcDckaaiuHtJsWqJ/ZG975lTjmAIPeoPWaIF8A/BBGf5wPo9Y7vo3ogzaOm234 0gemdMLflmo+SSnKWpD+RfrD3g5uwKGYiNWXksx36hsYrMxm+H3grcKN+lBiQn1R23vs BSPA== X-Gm-Message-State: AOJu0YwNrUZkgJq8oT3RQuOlk3OXRdniG5tYWkHKXURaQXkRS3YVArR4 jKK5MYW+yw8RjrryGj2YruScHyy8AB/edACJZTAtKKfm/9Tb73xhduBAZlm5GMbYM2FUDukBQa8 = X-Google-Smtp-Source: AGHT+IE9u35O8kgHq7/nL/RJRk0vB0eplgstYsE9o1wCxlGQo+JCVxlvabDwr9Eu+fFBAJs0N2wqSQ== X-Received: by 2002:a17:90b:3890:b0:2c9:6a38:54e4 with SMTP id 98e67ed59e1d1-2e77f75013bmr5518955a91.41.1729870793467; Fri, 25 Oct 2024 08:39:53 -0700 (PDT) Received: from chenghaoyang-low.c.googlers.com.com (199.211.81.34.bc.googleusercontent.com. [34.81.211.199]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e8e3555e09sm1612815a91.12.2024.10.25.08.39.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2024 08:39:52 -0700 (PDT) From: Harvey Yang To: libcamera-devel@lists.libcamera.org Cc: Harvey Yang Subject: [PATCH v4 0/2] Add U16 & U32 support in controls Date: Fri, 25 Oct 2024 15:38:49 +0000 Message-ID: <20241025153948.1213629-1-chenghaoyang@chromium.org> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi folks, This series of patches adds Unsigned int 16 & 32 support in controls, which are needed for metadata & ext controls perspectively. This passes gitlab pipeline: https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1297633 Updates in v4: - Added U32 & U16 entries in V4L2Device::getControls. Updates in v3: - Commit messages. - Added unit tests. Updates in v2: - Added default potential array `size = 0;`. - Removed unrelated debug message changes. BR, Harvey Yudhistira Erlandinata (2): libcamera: Extend u32 control type libcamera: Extend u16 control type include/libcamera/controls.h | 14 ++++++ src/libcamera/controls.cpp | 20 ++++++++- src/libcamera/v4l2_device.cpp | 27 +++++++++++ test/controls/control_value.cpp | 80 +++++++++++++++++++++++++++++++++ 4 files changed, 139 insertions(+), 2 deletions(-)