From patchwork Fri Oct 18 14:12:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Milan Zamazal X-Patchwork-Id: 21677 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A7F73C32AF for ; Fri, 18 Oct 2024 14:12:53 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C6E6B6538B; Fri, 18 Oct 2024 16:12:52 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="fyNMWhrs"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 82490633C6 for ; Fri, 18 Oct 2024 16:12:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729260770; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=s4m8/RfgUBvHuPXQlaIFJLUW3T05pA1s6E3l5chNgzk=; b=fyNMWhrsvPPIgWMJPyPyzln6fRAu3FWPGbMzhTCvNW0tAkuXhM8I5ml+xwwPg9GxUR0daG T5758KtQ8y0u1prRfSFlXWFikeNhn4u4rcp3wVBWak/3AjsbaDs1UJMzZsXzWovbZLZ2PX yeGqdHLePMVpQkJTZM5zmqdPhRLMmy0= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-448-BZw3NxPmOZe82FTbonPUKA-1; Fri, 18 Oct 2024 10:12:47 -0400 X-MC-Unique: BZw3NxPmOZe82FTbonPUKA-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 085701935797; Fri, 18 Oct 2024 14:12:46 +0000 (UTC) Received: from nuthatch.redhat.com (unknown [10.45.225.61]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 194FF19560A2; Fri, 18 Oct 2024 14:12:43 +0000 (UTC) From: Milan Zamazal To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Daniel Scally , Kieran Bingham , Robert Mader Subject: [PATCH v6 0/2] Get black level from the camera helper Date: Fri, 18 Oct 2024 16:12:35 +0200 Message-ID: <20241018141241.948698-1-mzamazal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This patch takes the black level value for the given sensor from its specification, if available. The initial intention was to get the value from the tuning file but in the meantime the value was added to CameraSensorHelper so it’s taken from there. Changes in v6: - A forgotten testing statement removed. - Using shift instead of division on the tuning value. Changes in v5: - Added a patch to take black level from the tuning file. Changes in v4: - Added braces around a single-line ‘if’ with a comment. Changes in v3: - A clarifying comment about the bit widths added. Changes in v2: - Rebased on the merged version of software ISP refactoring. - The black level is represented as a pixel value rather than a 0..1 floating value. Milan Zamazal (2): libcamera: software_isp: Get black level from the camera helper libcamera: software_isp: Black level from tuning file src/ipa/simple/algorithms/blc.cpp | 19 ++++++++++++++++++- src/ipa/simple/algorithms/blc.h | 1 + src/ipa/simple/ipa_context.h | 4 ++++ src/ipa/simple/soft_simple.cpp | 11 +++++++++++ 4 files changed, 34 insertions(+), 1 deletion(-)