From patchwork Fri Oct 18 09:26:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Milan Zamazal X-Patchwork-Id: 21670 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8596DC32FE for ; Fri, 18 Oct 2024 09:26:47 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A274165379; Fri, 18 Oct 2024 11:26:46 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="Iza0rtqF"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A278365379 for ; Fri, 18 Oct 2024 11:26:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729243603; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=K7QWf7crQHKThm7ElS1wt/qU2fCHguFFeZo2Ho4rQ18=; b=Iza0rtqFrmNTGwnnCz6uC5Tas5792aKPMS1Y/fD58EShucX6deCo+4C9/jCxmVwqEE13ma bX7Yg4s5AQU5SE2Raw1bj/0SrHtlSMOcEU7Pl1Oi2NIj44V+ShTp73O/SUKceZUeRIcUMZ F0NjFYP+4ZEoLBnLcD739i5X5M/POF0= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-620-BJhPfurWORC0FF-9jabFgQ-1; Fri, 18 Oct 2024 05:26:38 -0400 X-MC-Unique: BJhPfurWORC0FF-9jabFgQ-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 267BF19560A2; Fri, 18 Oct 2024 09:26:37 +0000 (UTC) Received: from nuthatch.redhat.com (unknown [10.45.225.61]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1A44719560AD; Fri, 18 Oct 2024 09:26:34 +0000 (UTC) From: Milan Zamazal To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Daniel Scally , Kieran Bingham , Robert Mader Subject: [PATCH v5 0/2] Get black level from the camera helper Date: Fri, 18 Oct 2024 11:26:26 +0200 Message-ID: <20241018092628.293586-1-mzamazal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This patch takes the black level value for the given sensor from its specification, if available. The initial intention was to get the value from the tuning file but in the meantime the value was added to CameraSensorHelper so it’s taken from there. Changes in v5: - Added a patch to take black level from the tuning file. Changes in v4: - Added braces around a single-line ‘if’ with a comment. Changes in v3: - A clarifying comment about the bit widths added. Changes in v2: - Rebased on the merged version of software ISP refactoring. - The black level is represented as a pixel value rather than a 0..1 floating value. Milan Zamazal (2): libcamera: software_isp: Get black level from the camera helper libcamera: software_isp: Black level from tuning file src/ipa/simple/algorithms/blc.cpp | 15 ++++++++++++++- src/ipa/simple/algorithms/blc.h | 1 + src/ipa/simple/ipa_context.h | 4 ++++ src/ipa/simple/soft_simple.cpp | 11 +++++++++++ 4 files changed, 30 insertions(+), 1 deletion(-)