From patchwork Thu Oct 17 12:46:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikhail Rudenko X-Patchwork-Id: 21650 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 415ADC32FC for ; Thu, 17 Oct 2024 12:46:26 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1E3C765384; Thu, 17 Oct 2024 14:46:24 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="md0D9aOE"; dkim-atps=neutral Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 83BDA6353B for ; Thu, 17 Oct 2024 14:46:21 +0200 (CEST) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-539ee1acb86so1158464e87.0 for ; Thu, 17 Oct 2024 05:46:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729169180; x=1729773980; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0uzorwYXRS4N7rwNx6qVWsGkIzmQMxbT/0RHX0r2SgA=; b=md0D9aOEzamtjbKFIyFL1l1fHlWRCHWIq3cJYWhtsiFNxLSRu9TPrJrj94ZliLF6dS sv/0W7CJHfKW8ayiDDRgzN1NKw+ZvtmCy1Hk3Bh4VnUkbzLYXW8A6ZZigMYAGFUiOVDG 6jpcux9Tye/8wgTOQ8W7OGXKtHaXoKESWDpvLKcXOSBhjzXD3IZWd571Y1zflbLhii72 iqDc0wtJasnZmUAXKExRzK0m9ChPI/vrmazudZUMHSzr/fWudtpeQ828s/5h2QZZLujd ZZybsoSEncaC1fct/nsS0wZ2RFG2M3fbHc36wDWmzdlVN/2BCpM4UDnjCU6awgFcgR1f Fy+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729169180; x=1729773980; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0uzorwYXRS4N7rwNx6qVWsGkIzmQMxbT/0RHX0r2SgA=; b=n0Vju392ytOOZrJzgD2qC0Pnd3l5bv0rtCAhWgJdhXBcWCjrhNJJYPzn5kiWPahD2p RSRNeZdcsCYt53mw4S7liNFI8Qrm3Ei1+ajRyG5TehFewuOUtyxh9vfwcZcZ8Bjug1wR OKD4Ew9J++wshNldd5nQiRvD+7pRKfNyue4U2/kOo6wQwqTeItyR2kEDl4L4oAaLbSMx BMyjCQwLaq1rs/Xz82CX2Y2SX8Jfelp/Z0hvkRiLizqjY4fqhP7jHi3syhLVwh3GOze2 BJfXu/PqBjgFasc+BMgHqdG0MUZ8jid/Y46MZO149nP1iZHRkWnvqtzV90mdvQscLqUa lAtg== X-Gm-Message-State: AOJu0YykUqlKnbNemthwEhyLUgktOOKh4KU/AWz0Z34eWttUv/P2Ah1r zZeFlx5DqnGFsFT75/p/QepMA8DhtC9t57/QlEdLQweYA7k6oc6hzt5PwA== X-Google-Smtp-Source: AGHT+IFd2cTkrDpYE5ULAIWYTFtQu87G9UBSKYMtMSJtGd+Ceiswju3x750TOdTG77KtQUuN0ED6jQ== X-Received: by 2002:a05:6512:3d23:b0:536:a6c6:33f with SMTP id 2adb3069b0e04-539e54e82f9mr10816364e87.13.1729169179388; Thu, 17 Oct 2024 05:46:19 -0700 (PDT) Received: from localhost ([83.149.246.185]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-539ffff37efsm758530e87.159.2024.10.17.05.46.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2024 05:46:18 -0700 (PDT) From: Mikhail Rudenko To: libcamera-devel@lists.libcamera.org Cc: Mikhail Rudenko Subject: [PATCH 0/3] Reduce rkisp1 flicker on first start Date: Thu, 17 Oct 2024 15:46:10 +0300 Message-ID: <20241017124613.3853273-1-mike.rudenko@gmail.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This small series aims at reducing rkisp1 startup flicker due to suboptimal defaults and the lack of coordination between the pipeline handler and the AGC algorithm. Analogue gain and exposure time charts from libcamera are attached to a reply to this message. Mikhail Rudenko (3): ipa: rkisp1: agc: Use better default value for analogue gain utils: ipc: Allow start method with output parameters in IPA proxies rkisp1: synchronize sensor controls with IPA include/libcamera/ipa/rkisp1.mojom | 2 +- src/ipa/rkisp1/algorithms/agc.cpp | 8 ++++++-- src/ipa/rkisp1/ipa_context.h | 2 ++ src/ipa/rkisp1/rkisp1.cpp | 19 +++++++++++++++---- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 6 +++++- .../module_ipa_proxy.h.tmpl | 11 ++++------- .../module_ipa_proxy_worker.cpp.tmpl | 2 +- 7 files changed, 34 insertions(+), 16 deletions(-) --- 2.46.0