From patchwork Mon Oct 14 19:10:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Milan Zamazal X-Patchwork-Id: 21624 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 64FA4C326C for ; Mon, 14 Oct 2024 19:11:13 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 39A1465381; Mon, 14 Oct 2024 21:11:12 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="jRHLid7F"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CFB066537C for ; Mon, 14 Oct 2024 21:11:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728933069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Aqh5ql+B4TsaAcJjyQ+m2MpcCf8hZZ/KcVKN7lSVosQ=; b=jRHLid7F4r8JTwvKpc4Y79H7WloKfEw86RCu+48VQrl2heBTcJlyEzLdpCemHydNRWCghG GAEMAsGrzxIeSmyU9mOuoaI2aURDx0i2yEASsE45/olNTybK8Ed+xRJC336s5rtZYC3n8H UJpu6ev1iYligw+4OLS1RiikR4hHB78= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-5IYwePgRPS6jsZmN-hgcag-1; Mon, 14 Oct 2024 15:11:04 -0400 X-MC-Unique: 5IYwePgRPS6jsZmN-hgcag-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8C1381955EA7; Mon, 14 Oct 2024 19:11:03 +0000 (UTC) Received: from nuthatch.redhat.com (unknown [10.45.224.20]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8FF0119560AA; Mon, 14 Oct 2024 19:11:01 +0000 (UTC) From: Milan Zamazal To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Daniel Scally , Kieran Bingham , Robert Mader Subject: [PATCH v4 0/1] Get black level from the camera helper Date: Mon, 14 Oct 2024 21:10:56 +0200 Message-ID: <20241014191058.1812307-1-mzamazal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This patch takes the black level value for the given sensor from its specification, if available. The initial intention was to get the value from the tuning file but in the meantime the value was added to CameraSensorHelper so it’s taken from there. Changes in v4: - Added braces around a single-line ‘if’ with a comment. Changes in v3: - A clarifying comment about the bit widths added. Changes in v2: - Rebased on the merged version of software ISP refactoring. - The black level is represented as a pixel value rather than a 0..1 floating value. Milan Zamazal (1): libcamera: software_isp: Get black level from the camera helper Milan Zamazal (1): libcamera: software_isp: Get black level from the camera helper src/ipa/simple/algorithms/blc.cpp | 6 +++++- src/ipa/simple/ipa_context.h | 4 ++++ src/ipa/simple/soft_simple.cpp | 10 ++++++++++ 3 files changed, 19 insertions(+), 1 deletion(-)