From patchwork Fri Oct 11 15:39:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Milan Zamazal X-Patchwork-Id: 21590 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id DEB9EC3260 for ; Fri, 11 Oct 2024 15:39:47 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E35E165370; Fri, 11 Oct 2024 17:39:46 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="cP3HzZM/"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4CD076353B for ; Fri, 11 Oct 2024 17:39:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728661184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Tf7VoMqugvC65P3MYk5/VtzTg73n7NHJDkWl4sRcP4o=; b=cP3HzZM/+jbuwKyFLAqWfomcpmfP2EWTAfnjKwjeehfcALmSaAX7KxnIJOCT279fxsGphj so4ZXXjbDPCIQAlx9avqad2G0lQLMjlL655ta2tET+VxsyRGIceOjcl7vZ7gt04RZOtPxW eAJJ9t/t7am7pxfWvFNul0neStbjUUk= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-650-c75sYodvO6G5cHMl--dw2g-1; Fri, 11 Oct 2024 11:39:40 -0400 X-MC-Unique: c75sYodvO6G5cHMl--dw2g-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BE8E719560BE; Fri, 11 Oct 2024 15:39:39 +0000 (UTC) Received: from nuthatch.redhat.com (unknown [10.45.224.99]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C87A81955E8F; Fri, 11 Oct 2024 15:39:37 +0000 (UTC) From: Milan Zamazal To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Daniel Scally , Kieran Bingham Subject: [PATCH v3 0/1] Get black level from the camera helper Date: Fri, 11 Oct 2024 17:39:31 +0200 Message-ID: <20241011153934.1291362-1-mzamazal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This patch takes the black level value for the given sensor from its specification, if available. The initial intention was to get the value from the tuning file but in the meantime the value was added to CameraSensorHelper so it’s taken from there. Changes in v3: - A clarifying comment about the bit widths added. Changes in v2: - Rebased on the merged version of software ISP refactoring. - The black level is represented as a pixel value rather than a 0..1 floating value. Milan Zamazal (1): libcamera: software_isp: Get black level from the camera helper src/ipa/simple/algorithms/blc.cpp | 6 +++++- src/ipa/simple/ipa_context.h | 4 ++++ src/ipa/simple/soft_simple.cpp | 9 +++++++++ 3 files changed, 18 insertions(+), 1 deletion(-)