From patchwork Tue Oct 8 10:19:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 21534 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 316C9BD80A for ; Tue, 8 Oct 2024 10:19:35 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 066E76353B; Tue, 8 Oct 2024 12:19:34 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="LSpF58MM"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 885F1618C9 for ; Tue, 8 Oct 2024 12:19:32 +0200 (CEST) Received: from localhost.localdomain (unknown [IPv6:2405:201:2015:f873:55f8:639e:8e9f:12ec]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DEF013D6; Tue, 8 Oct 2024 12:17:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1728382676; bh=m5tICAAfvBtRGGElwO2vCuibXWR3LLuLUWRll0aIMxY=; h=From:To:Cc:Subject:Date:From; b=LSpF58MMRCHa+rCPkkAkT+bO3+wK22K5X0pO+STYxulzOuOQuNG1Y2za3lwmHd9eP 3WucCWS3aLoigpBYTl7Mwn4dj3xIBvHd4nehf7ODBKeKurBfgOAqULiFyPpt2scew9 pN4jKzQY9U9dHYCiVKpd3YZYCkz/BAqLLWZh3woM= From: Umang Jain To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Paul Elder , Umang Jain Subject: [PATCH v5 0/1] rkisp1: Integrate sensorConfiguration Date: Tue, 8 Oct 2024 15:49:17 +0530 Message-ID: <20241008101918.10414-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.45.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" 1/1 integrates sensor configuration in rkisp1. Changes in v5: - on RAW stream path, compare sensorFormat's size returned from CameraSensor::getFormat() to streamConfiguration->outputsize Changes in v4: - Fix bitDepth handling in RkISP1Path - Unify 2 if(sensorConfig) branches in RkISP1 - Remove {} (nits) - maxResolution should be bounded first before bounding to aspect ratio - drop "std::optional" from bitDepth variable Changes in v3: - Drop isRaw() dependency - rework commit message to elaborate cases of sensor configuration failure Changes in v2: - Validate sensor resolution in RkISP1Path::validate() instead of RkISP1 - Pass sensorConfiguration by reference - Do not adjust sensor Configuration, always return CameraConfiguration::Invalid if sensor configuration cannot be satisfied - Apply sensor configuration at configure() time v1: - https://patchwork.libcamera.org/patch/21463/ - Developed over [PATCH] libcamera: rkisp1: Clamp stream configuration to ISP limit on raw path - Tested with cam+[1] on i.MX8MP with IMX283 attached [1]: https://patchwork.libcamera.org/patch/20080/ Umang Jain (1): libcamera: rkisp1: Integrate SensorConfiguration support src/libcamera/pipeline/rkisp1/rkisp1.cpp | 42 +++++++++++++--- src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 48 +++++++++++++++++-- src/libcamera/pipeline/rkisp1/rkisp1_path.h | 2 + 3 files changed, 80 insertions(+), 12 deletions(-)