From patchwork Fri Oct 4 12:21:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 21521 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C2AD4BD80A for ; Fri, 4 Oct 2024 12:21:13 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4408F63524; Fri, 4 Oct 2024 14:21:12 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="XZrV3Ahk"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 891AF62C8F for ; Fri, 4 Oct 2024 14:21:10 +0200 (CEST) Received: from umang.jain (unknown [IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 154D24C9; Fri, 4 Oct 2024 14:19:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1728044376; bh=fWHwl5rf+0nFwo4V6xObRc/MuWqYdCccieePkISOYvg=; h=From:To:Cc:Subject:Date:From; b=XZrV3Ahkq+XtMhsfv5zzVEipYGghyXeW/kSn25BhAOtq3Dpbb5epaSPjkflI7HQ7U szDnwS9gCsj+mzDHJnb187rE7EyCb8ztTtf/8Ks0mTyMnpNr95cu9XVHkNVB2a2z+G kocl1V54hlp/gShLMgvT9+Y6HOppR4CrjnXkxnH0= From: Umang Jain To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Paul Elder , Stefan Klug , Umang Jain Subject: [PATCH v4 0/1] rkisp1: Integrate sensorConfiguration Date: Fri, 4 Oct 2024 17:51:02 +0530 Message-ID: <20241004122103.89807-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" 1/1 integrates sensor configuration in rkisp1. Changes in v4: - Fix bitDepth handling in RkISP1Path - Unify 2 if(sensorConfig) branches in RkISP1 - Remove {} (nits) - maxResolution should be bounded first before bounding to aspect ratio - drop "std::optional" from bitDepth variable Changes in v3: - Drop isRaw() dependency - rework commit message to elaborate cases of sensor configuration failure Changes in v2: - Validate sensor resolution in RkISP1Path::validate() instead of RkISP1 - Pass sensorConfiguration by reference - Do not adjust sensor Configuration, always return CameraConfiguration::Invalid if sensor configuration cannot be satisfied - Apply sensor configuration at configure() time v1: - https://patchwork.libcamera.org/patch/21463/ - Developed over [PATCH] libcamera: rkisp1: Clamp stream configuration to ISP limit on raw path - Tested with cam+[1] on i.MX8MP with IMX283 attached [1]: https://patchwork.libcamera.org/patch/20080/ Umang Jain (1): libcamera: rkisp1: Integrate SensorConfiguration support src/libcamera/pipeline/rkisp1/rkisp1.cpp | 42 ++++++++++++++--- src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 47 +++++++++++++++++-- src/libcamera/pipeline/rkisp1/rkisp1_path.h | 2 + 3 files changed, 79 insertions(+), 12 deletions(-)