From patchwork Wed Sep 25 15:21:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 21369 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 9D1E3C3257 for ; Wed, 25 Sep 2024 15:21:41 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 115E26350F; Wed, 25 Sep 2024 17:21:40 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="cr162bNI"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 07F7D634F4 for ; Wed, 25 Sep 2024 17:21:38 +0200 (CEST) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DE5B0A30; Wed, 25 Sep 2024 17:20:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1727277610; bh=LOnJuM/kTWWgQZi5nHbPceZVl5yXYlph+HqY7vXLgOM=; h=From:To:Cc:Subject:Date:From; b=cr162bNIErx9QUknRxMJlZp87exqIwNF9/1ZhC5IcjLyi2LC9nWBmBIA5cxU7kLQs CAKAGJ63lbJ1EM5eisshJLt1wS8XzKQLzdrVcHPK2hJQct/YAaLlQilcU+rLL4u470 1b6MYnUAuNcmxJjrE8JZQzLFvU3lCI9HmxMg5n/o= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Cc: Arne Caspari Subject: [PATCH 0/2] apps: cam: Improve user experience with DNG capture Date: Wed, 25 Sep 2024 18:21:32 +0300 Message-ID: <20240925152134.20284-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, This small patch series stems from a request for help on the libcamera IRC channel, related to DNG files produced by the cam tool that could not be parsed by the tuning tools. It turned out that cam was compiled without libtiff, which disabled DNG capture, and then silently captured raw binary files instead of DNG files. Patch 1/2 is a small cleanup, and patch 2/2 fixes the issue by producing an error when DNG capture is requested but DNG support isn't available. Laurent Pinchart (2): apps: Replace HAVE_DNG with HAVE_TIFF apps: cam: Print an error when outputting DNG and DNG support is missing src/apps/cam/camera_session.cpp | 15 ++++++--- src/apps/cam/file_sink.cpp | 60 +++++++++++++++++++++++---------- src/apps/cam/file_sink.h | 18 ++++++++-- src/apps/common/dng_writer.h | 1 - src/apps/qcam/main_window.cpp | 4 +-- 5 files changed, 70 insertions(+), 28 deletions(-) base-commit: 8bcec687344e5cc2ccef1361c03b87f0fd2cc59b