From patchwork Mon Sep 16 04:51:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cheng-Hao Yang X-Patchwork-Id: 21278 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B372DC3257 for ; Mon, 16 Sep 2024 04:58:16 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A3020634FD; Mon, 16 Sep 2024 06:58:15 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="d3Y/wzrs"; dkim-atps=neutral Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C704618E3 for ; Mon, 16 Sep 2024 06:58:13 +0200 (CEST) Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-718e3c98b5aso2677813b3a.0 for ; Sun, 15 Sep 2024 21:58:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1726462691; x=1727067491; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vt+F6Gx1EW4w19X7jkYCEZKCkX7oeYRk4LgxKfpnNgc=; b=d3Y/wzrsX2G82yFPQae3xjrmimRyo5+W3Prg11gyeCd+NjYqKtj5FsPtLsRUbkA3Uz nluCKqZtf8kjqWYL/46tQDfBy9uIpYMjlKoAgmnkJfFZ5zWBENbAuIlBVttKItSv00rM RGGiasWEkS12A09RSH1eymWmc3D8Yuehh2NhI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726462691; x=1727067491; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vt+F6Gx1EW4w19X7jkYCEZKCkX7oeYRk4LgxKfpnNgc=; b=H5AFrj8jnu32S8cZlktbI4tT/meKz+N39YBmBpGI3KuHm+npke5GcFtW05vNerlg/p ZmmLJTWCSQ/UWju3WHpALRGuDjmu8ryJlaBCdKJZfnZswpqebQUv5H0AvWEUw5AAwGGU iXQsOfgzHSeqlCTLMJSwpzD/BxWsXPgH4dpyk1ZZvaLDVGCWh8Wqcn08FTe3EgmbLN+N YCyUBbD65ayDo+1rrL+pLMumQMGyTQtYBciB/vtaHsW5No1R/zDRv+w0z+PyZrP2F7Ul m+uRpuXbWoFJKJ4o4H06aUJga9/klKnoRB0vGuZY9j0Tkf9EkhyWnGwX9dsrZMcvQ64c dFiw== X-Gm-Message-State: AOJu0YwI22lRX9rSy3xo59jUD/yQeQgDzo0Mp5KT33yFchKHv82WeLKX RlVap9aGF1BOpEftC2ppYkyWS5UTTqqMscORHug2DM5BXAwOOfrsfdM/90ojYnj0L2dZ9FXRp5o = X-Google-Smtp-Source: AGHT+IFrMW3xI1l4YK0im6/ZtRLnYTNa7wxpDJjxSCKUDblWidNsoUdd4Gdc4T2XN63scL3ykhjAEA== X-Received: by 2002:a05:6a00:ac9:b0:718:d8dc:308a with SMTP id d2e1a72fcca58-7192606c44emr20998632b3a.12.1726462691479; Sun, 15 Sep 2024 21:58:11 -0700 (PDT) Received: from chenghaoyang-low.c.googlers.com.com (208.158.221.35.bc.googleusercontent.com. [35.221.158.208]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944ab5590sm2996267b3a.65.2024.09.15.21.58.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Sep 2024 21:58:10 -0700 (PDT) From: Harvey Yang X-Google-Original-From: Harvey Yang To: libcamera-devel@lists.libcamera.org Cc: Harvey Yang Subject: [PATCH 0/1] Add StreamRole into StreamConfiguration Date: Mon, 16 Sep 2024 04:51:54 +0000 Message-ID: <20240916045802.3799103-1-chenghaoyang@google.com> X-Mailer: git-send-email 2.46.0.662.g92d0881bb0-goog MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi folks, Currently applications set resolutions, pixelFormat, bufferCount, etc, into StreamConfigurations, and Pipeline Handler decides which streams they're assigned to. However, it doesn't allow application to assign streams that cannot be distinguished by those arguments into VideoRecording or StillCapture (say YUV/NV12 format), which is needed in mtkisp7. This patch allows application to set the desired StreamRole directly. This patch passed gitlab pipeline: https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1271770 It might be controversial. Let me know the concerns. Thanks! BR, Harvey Han-Lin Chen (1): libcamera: Add StreamRole into StreamConfiguration include/libcamera/stream.h | 2 ++ src/libcamera/stream.cpp | 12 ++++++++++-- 2 files changed, 12 insertions(+), 2 deletions(-)