From patchwork Fri Sep 13 10:37:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 21259 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id ACD8CC3257 for ; Fri, 13 Sep 2024 10:38:10 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7A28C634FE; Fri, 13 Sep 2024 12:38:09 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="jTjgDnva"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4E3CE634E3 for ; Fri, 13 Sep 2024 12:38:07 +0200 (CEST) Received: from ATX.abc.com (unknown [IPv6:2405:201:2015:f873:55f8:639e:8e9f:12ec]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E376A74C; Fri, 13 Sep 2024 12:36:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1726223808; bh=BmC6AKXuE9UyaLcQ2ydvdoPwf2RJBuS3TKK4U1jFmpw=; h=From:To:Cc:Subject:Date:From; b=jTjgDnvaBvcQK70sSiBalHsfsyao8liePKz6iM4GKUQdys3kken/a5dDgvuOm6JRW I2/SLbClv+UJ3YCbGJW5azU5pkA+Cv/bU6LE25MBp+xRXaU5txXrO3qnj+8Bna12yN rJronePLqdLC7KWTX8VLjlMAY2bhgcfvjbWONL/g= From: Umang Jain To: libcamera-devel@lists.libcamera.org Cc: Umang Jain Subject: [PATCH v2 0/2] pipeline: rkisp1: Filter out sensor sizes not supported by the pipeline Date: Fri, 13 Sep 2024 16:07:57 +0530 Message-ID: <20240913103759.2166-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.45.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The series targets fixing and improving maximum resolutions that can be streamed on the pipeline, successfully. 1/2 targets fixing the issue where the RkISP1MainPath was considering max supported size > ISP on i.MX8MP. 2/2 filters out sensor sizes that cannot be supported by the pipeline. Such sizes are filtered out and the highest resolution (supported by sensor) is considered as the max sensor resolution for generateConfiguration() and validate() code paths. Previous attempts: https://patchwork.libcamera.org/patch/20699/ https://patchwork.libcamera.org/patch/19411/ Based on series: libcamera: rkisp1: Plumb the dw100 dewarper as V4L2M2M converter v7 Changes in v2: - Use const for variables in 1/2 - Add comment on why we need to bound max size 1/2 - Use std::map<> in 2/2 for sensor sizes as multiple sensor can be attached to same ISP. Umang Jain (2): pipeline: rkisp1: Bound RkISP1 path to ISP maximum input pipeline: rkisp1: Filter out sensor sizes not supported by the pipeline src/libcamera/pipeline/rkisp1/rkisp1.cpp | 15 ++++- src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 64 ++++++++++++++++++- src/libcamera/pipeline/rkisp1/rkisp1_path.h | 10 ++- 3 files changed, 83 insertions(+), 6 deletions(-)