From patchwork Tue Sep 10 23:46:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 21224 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id DF2F8BF415 for ; Tue, 10 Sep 2024 23:47:25 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id DFDA7634EB; Wed, 11 Sep 2024 01:47:24 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="nrcDFzvV"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 93440634EB for ; Wed, 11 Sep 2024 01:47:23 +0200 (CEST) Received: from pendragon.ideasonboard.com (213-229-8-243.static.upcbusiness.at [213.229.8.243]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 274D15A5; Wed, 11 Sep 2024 01:46:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1726011966; bh=SaL2pt7oZX00R8pyy4RcWHMUrMpMjkRgANsiRhmuEn0=; h=From:To:Cc:Subject:Date:From; b=nrcDFzvVtwCoqcihPnudikb674yp87vPdVTrXcsEjh/poc43qyDAr4dczgYLMzu13 qvK/g4zuDywmcZpal3y7SOHgxzzGEfDJVMsYJAtWImmQ0zDi7krdbkC1Pz1dMSxcl5 GWpq/VHpdeBM8Acr1vxl+DWezSrNAeZgGINEnJ3U= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Cc: Neal Gompa Subject: [PATCH 0/3] qcam: Fix GL renderer on Qt 6 Date: Wed, 11 Sep 2024 02:46:46 +0300 Message-ID: <20240910234649.28591-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.44.2 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, This small series fixes the GL render with Qt 6. The fix is actually in patch 1/3 only, with patches 2/3 and 3/3 bringing additional cleanups and improvements. Laurent Pinchart (3): qcam: viewfinder_gl: Fix binding of vertex buffer and shader program qcam: viewfinder_gl: Drop duplicate glClearColor() qcam: viewfinder_gl: Render image centered in letterbox src/apps/qcam/assets/shader/bayer_8.vert | 4 +- src/apps/qcam/assets/shader/identity.vert | 3 +- src/apps/qcam/viewfinder_gl.cpp | 54 ++++++++++++++--------- src/apps/qcam/viewfinder_gl.h | 2 +- 4 files changed, 39 insertions(+), 24 deletions(-) base-commit: f75b8dd26feaca86701704390dea18c71e2f0350 Tested-by: Kieran Bingham Reviewed-by: Kieran Bingham Reviewed-by: Neal Gompa