From patchwork Fri Aug 30 21:00:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cheng-Hao Yang X-Patchwork-Id: 21124 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B25CCC323E for ; Fri, 30 Aug 2024 21:03:19 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id DE7B7634CA; Fri, 30 Aug 2024 23:03:18 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="W5E6OBwI"; dkim-atps=neutral Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9420261E4A for ; Fri, 30 Aug 2024 23:03:16 +0200 (CEST) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-42bb8cf8abeso15904405e9.2 for ; Fri, 30 Aug 2024 14:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1725051796; x=1725656596; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vvpGPs5qyoHP4Gevd/Ug/drJLe5/JESG1wBP7hFbINU=; b=W5E6OBwIwwDC4d12Wjk6mOno1+ICH3W0QihGyUxwQeS6FDGCtLl9r5rFjvS5g/ljfp BeYLZpNhnZy2fUmeUY+vsHcaLowRa2+vjhpvtD79q/0AlAntrCidk6/J9FkBDyIPkunm p9aO39OwZDUS6ltwN+OItMDKTh9OsAS2rZnrI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725051796; x=1725656596; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vvpGPs5qyoHP4Gevd/Ug/drJLe5/JESG1wBP7hFbINU=; b=wCi2S7RuoVWXNQmYys05mrdp+ckwhXLUsco61AV0Z14z9VtMqKeWJJ3Doj4TKGHweB Mm+L9qwpj94xy6dbtIzgoeqI6iE9PMHj3FhXJrn9JU5Kq6dd+tBpO3s9gKuCPLSnuG0I 7+cfUQ/aFGETJrMr2HNrG6qy/pWJYwfWg4M+XVtJf/fV/R0GQRYqUow+4nlxlUGQkucC vpdds+EnEGEBhQR12QrY9EEPbEWRS77MZ4e11b5nmjpa+SA0YPe5TV6tEdW1dGBOM4TN s/pK4O8s+QWS8/SqT3Gp0hQFH7lcNhZfrHiaM3L1kClTK+ZUBKv5t+bCrCAbJy6hHdV5 5k6Q== X-Gm-Message-State: AOJu0YzAlflWsRLlGeusS7sSGOMSzw2DuYDzMB0/tq8kgY5q08VnqKyP WlbYE+TDUtsxvvWw5QqbP0MN4YXykDCCeDN32gAcCvsHBmcCZQdexz9tN4gyBRj0DVNwJhO5IHy QVg== X-Google-Smtp-Source: AGHT+IFLaS7UJznS4Or/o6CBp8gEAeDK2gvUuT6YxIvGr4hzFJAcCV1cavJz0yLYTA10mWyfRTg1sw== X-Received: by 2002:a05:600c:354b:b0:42b:afa7:804e with SMTP id 5b1f17b1804b1-42bb01ae418mr56768085e9.3.1725051795405; Fri, 30 Aug 2024 14:03:15 -0700 (PDT) Received: from chenghaoyang-germany.c.googlers.com.com (161.126.77.34.bc.googleusercontent.com. [34.77.126.161]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3749efb37efsm4935529f8f.109.2024.08.30.14.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Aug 2024 14:03:14 -0700 (PDT) From: Harvey Yang To: libcamera-devel@lists.libcamera.org Cc: Harvey Yang Subject: [PATCH v3 0/3] Add Face Detection Controls Date: Fri, 30 Aug 2024 21:00:18 +0000 Message-ID: <20240830210313.30691-1-chenghaoyang@chromium.org> X-Mailer: git-send-email 2.46.0.469.g59c65b2a67-goog MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi folks, This series of patches adds face detection controls in the control ids, the corresponding usages, and a c'tor of libcamera::Rectangle to construct it easiler with face detection results. It passed gitlab pipeline checks: https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1261374 This is one of the series cherry-picked from cros mtkisp7 branch. The corresponding CLs in cros are: https://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/4741266 https://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/4741267 https://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/5669229 https://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/5669232 The usages in pipeline handler mtkisp7 will be added later. The checkstyle's suggestion on the second patch is ignored, as it changes the style of previous code. v3: Applied fixes according to Jacopo's comments. - Moved the new face detection controls from core to draft. - Amended new controls' descriptions. v2: - Squashed the fourth CL into the last patch, as it's a fix. - Fixed CLs based on checkstyle's suggestions. Harvey Yang (1): libcamera: android: Add face detection control support Yudhistira Erlandinata (2): libcamera: Add rectangle two-point constructor libcamera: Add face detection controls include/libcamera/controls.h | 6 +++ include/libcamera/geometry.h | 2 + src/android/camera_capabilities.cpp | 45 ++++++++++++++++++-- src/android/camera_device.cpp | 61 ++++++++++++++++++++++++++- src/libcamera/control_ids_draft.yaml | 63 ++++++++++++++++++++++++++++ src/libcamera/controls.cpp | 6 +++ src/libcamera/geometry.cpp | 14 +++++++ 7 files changed, 191 insertions(+), 6 deletions(-)