From patchwork Tue Aug 13 08:44:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 20893 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 2573EC323E for ; Tue, 13 Aug 2024 08:45:06 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E3DA9633B5; Tue, 13 Aug 2024 10:45:04 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="sEmg1eer"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 80B556337E for ; Tue, 13 Aug 2024 10:45:03 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:7025:8d00:1ffd:751a]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 52B06827; Tue, 13 Aug 2024 10:44:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1723538646; bh=5uAHcx72BklYBy4x9kEu/Urv9StUk3Y6/tIeGFqubqI=; h=From:To:Cc:Subject:Date:From; b=sEmg1eerQrNaMDd+hLtNe+ME7Iw3YPvGwbiSvnYuV0xpxYVi+9e7f8GtO3TGpv0I+ Yo8gFCZuTMBDGZ5F/0BldMWh+/n/zvBNfB25HBPVDWpqd1bpAvjeuP0wLb3O+fsWKf ghh8fdGwJTAkLQEezs3MYZ/EmlcmM9apHnXE9zjg= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v4 0/6] rkisp1: Add manual colour temperature control Date: Tue, 13 Aug 2024 10:44:17 +0200 Message-ID: <20240813084451.44099-1-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This series adds the ability to manually set the colour temperature control. It is a partial resurrection of the "libcamera: controls: Update the ColourTemperature control to be writable" series by David Plowman [1], but with a implementation for the rkisp1 instead of the rpi. Patch 1 updates the control id documentation. Patches 2-3 implement the control for the rkisp1. Patches 4-6 update the tuning scripts accordingly. It depends on the "Two small tuning script cleanups" series [2]. Please see the individual commit messages for more details. Changes v1 -> v4: - Incremented series version to v4, because technically it is a superset of [1] - Fixed compile issue on patch 2 - Fixed typos and wording in patch 1 - Collected tags Best regards, Stefan [1] https://patchwork.libcamera.org/project/libcamera/list/?series=4083 [2] https://patchwork.libcamera.org/project/libcamera/list/?series=4484 Stefan Klug (6): libcamera: controls: Update the ColourTemperature control to be writable ipa: rkisp1: awb: Load white balance gains from tuning file ipa: rkisp1: awb: Implement ColourTemperature control libtuning: Modify ctt_awb.awb() so that it can run in our context libtuning: Add initial AWB module utils: tuning: rkisp1: Replace static AWB with new AWB module src/ipa/rkisp1/algorithms/awb.cpp | 38 +++++++++++++ src/ipa/rkisp1/algorithms/awb.h | 6 ++ src/libcamera/control_ids_core.yaml | 24 ++++++-- utils/tuning/libtuning/ctt_awb.py | 55 ++++++++++--------- .../tuning/libtuning/modules/awb/__init__.py | 6 ++ utils/tuning/libtuning/modules/awb/awb.py | 42 ++++++++++++++ utils/tuning/libtuning/modules/awb/rkisp1.py | 27 +++++++++ utils/tuning/rkisp1.py | 4 +- 8 files changed, 170 insertions(+), 32 deletions(-) create mode 100644 utils/tuning/libtuning/modules/awb/__init__.py create mode 100644 utils/tuning/libtuning/modules/awb/awb.py create mode 100644 utils/tuning/libtuning/modules/awb/rkisp1.py