From patchwork Wed Jul 17 10:09:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 20686 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C249BBDB1C for ; Wed, 17 Jul 2024 10:09:31 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C0AFD6337C; Wed, 17 Jul 2024 12:09:29 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="TT4O/GVL"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 45BC963369 for ; Wed, 17 Jul 2024 12:09:27 +0200 (CEST) Received: from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it [93.61.96.190]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 26D84836; Wed, 17 Jul 2024 12:08:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1721210929; bh=k/fPy9h1ZXLzfclAyKMDhzul1qjuOIr4wPHbKAJYR0A=; h=From:To:Cc:Subject:Date:From; b=TT4O/GVLnr1cQ3D7y2Ohe6EYsNDRTrVre9D7g5McMyU7LOgwLo5z1+ySinKsARuls 8k/ymK72uzPILLinHgYk5i09ni7Qxr5YJX40wlMGt9O8blTaS/0tIOkco3TYxyG9hy ftATpCaa2y8bsuiKslavOAzIr0XBIsmWuxFG+nGE= From: Jacopo Mondi To: Umang Jain , libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi Subject: [RFC 0/9] Handle Converter features differently Date: Wed, 17 Jul 2024 12:09:03 +0200 Message-ID: <20240717100913.16640-1-jacopo.mondi@ideasonboard.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Umang, this is a series of patches on top of yours to consider an alternative approach to specify a converter's capabilities at registration time. Have a look and let me know what you think. Thanks j Jacopo Mondi (4): fixup: Add Features at Converter registration time libcamera: converter: Allow registering with feature fixups: Make it compile dw100: fixup Umang Jain (5): libcamera: converter: Add interface for feature flags libcamera: converter: Add interface to support cropping capability libcamera: rkisp1: Prepare for additional camera controls libcamera: converter: Add DW100 converter class libcamera: rkisp1: Plumb the ConverterDW100 converter include/libcamera/internal/converter.h | 46 ++++- .../internal/converter/converter_dw100.h | 24 +++ .../internal/converter/converter_v4l2_m2m.h | 8 +- .../libcamera/internal/converter/meson.build | 1 + src/libcamera/converter.cpp | 81 +++++++- src/libcamera/converter/converter_dw100.cpp | 44 +++++ .../converter/converter_v4l2_m2m.cpp | 89 ++++++++- src/libcamera/converter/meson.build | 1 + src/libcamera/pipeline/rkisp1/rkisp1.cpp | 176 +++++++++++++++++- src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 12 +- src/libcamera/pipeline/rkisp1/rkisp1_path.h | 14 ++ 11 files changed, 468 insertions(+), 28 deletions(-) create mode 100644 include/libcamera/internal/converter/converter_dw100.h create mode 100644 src/libcamera/converter/converter_dw100.cpp --- 2.45.2