From patchwork Mon Jul 8 12:38:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Milan Zamazal X-Patchwork-Id: 20613 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BF710BD87C for ; Mon, 8 Jul 2024 12:38:20 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 759B26336A; Mon, 8 Jul 2024 14:38:20 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="ek+we1yA"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C4B3563364 for ; Mon, 8 Jul 2024 14:38:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720442297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rMy4sQhnl/AyM+gglI8D7NsT+2bz9xo62v4v+4op14U=; b=ek+we1yAp6qUxrQXOcNBvT2w7dYDrSrNES4U3x7sB5n5SJF+CWoPs9uy5Of2kyHQqsjaBh kBMiGvnC6J2Q30xt0NgcbmN5Wpz2mMA7gZ0C9T8VSNdRpb0ptcNBYhZFa6Bi3kvHuve8kx S8BlqVnp8+YZMIkG73NDTBICDUpYeUM= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-452-Anc6tmwGPcGwpwz6MCfCQA-1; Mon, 08 Jul 2024 08:38:13 -0400 X-MC-Unique: Anc6tmwGPcGwpwz6MCfCQA-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 464921955BD2; Mon, 8 Jul 2024 12:38:12 +0000 (UTC) Received: from nuthatch.redhat.com (unknown [10.45.226.113]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6B88B1955E8C; Mon, 8 Jul 2024 12:38:10 +0000 (UTC) From: Milan Zamazal To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Kieran Bingham , Laurent Pinchart Subject: [PATCH v2 0/3] Fix misleading error messages Date: Mon, 8 Jul 2024 14:38:00 +0200 Message-ID: <20240708123803.1006689-1-mzamazal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" At least with software ISP, "errors" that have actually no influence on regular libcamera operation may be reported. This is confusing for users, especially in cases when there are other, real errors. Let's improve the given log messages a bit. Changes in v2: - The order of the patches swapped, to put the easier change first. - An empty line, as requested by Laurent, added. - Added a trivial patch to unify the IPAProxy::configurationFile argument name in the declaration and definition. - Added a new optional argument to IPAProxy::configurationFile for a fallback file, which solves the error/warning problem there. Milan Zamazal (3): libcamera: simple: Log a missing sensor in a better way libcamera: ipa_proxy: Unify configurationFile argument name libcamera: ipa_proxy: Report a missing configuration as a warning include/libcamera/internal/ipa_proxy.h | 4 +++- src/libcamera/ipa_proxy.cpp | 22 +++++++++++++++++---- src/libcamera/pipeline/ipu3/ipu3.cpp | 5 ++--- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++------- src/libcamera/pipeline/simple/simple.cpp | 4 +++- src/libcamera/software_isp/software_isp.cpp | 5 ++--- 6 files changed, 30 insertions(+), 19 deletions(-)