From patchwork Wed Jul 3 13:49:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 20507 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4D64FBD87C for ; Wed, 3 Jul 2024 13:50:08 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 37AF262E22; Wed, 3 Jul 2024 15:50:07 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="t7mB1jaN"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 206AD62C95 for ; Wed, 3 Jul 2024 15:50:06 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:9263:c199:9587:576]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C47E23D6; Wed, 3 Jul 2024 15:49:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1720014577; bh=xxaep0JbtP6HJ9SJeGefIJJd13m6qfg9ZnYcPGWw2vw=; h=From:To:Cc:Subject:Date:From; b=t7mB1jaNJxhtDD71w/qcp2U4KjJYpNIXH6sgXXADmYi4b4SuqjiNjAaFjRttUzU/5 mdsP8ZDjAq1x6JmsTWsid5kux3JfmXDak1Yv2ZqzWMAm2lm7FL38TrHYJG1TJDKKjk 9zkrU0Ydf4Lgef7cXtCt6BezojvWrhnbUHSBZihg= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v3 0/6] ipa: Add black level to camera sensor helpers Date: Wed, 3 Jul 2024 15:49:48 +0200 Message-ID: <20240703135000.242227-1-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" For the tuning process and the BLC block, the sensor black level needs to be known. The black level usually consists of a pedestal value added by the sensor and additional physical effects like dark currents. The sensors are usually programmed with fixed pedestal value or to target a defined black level using internal algorithms. We are not aware of any sensor driver that changes these values from the defaults mentioned in the datasheets. It therefore makes sense to keep that information inside libcamera. When the need arises to be more flexible we can extend the sensor drivers to report black level information. This series adds black level support to the camera sensor helpers and the corresponding metadata to the rkisp1 ipa. Aditionally it removes the black level information from the existing tuning files. When we observe that the hardcoded values are too far off from actual measurements an additional offset can be added to the tuning files. My tuning series will be rebased on top of this one. Best regards, Stefan Changes in v2: - Store a single int16_t black level inside camera sensor helper. This is sufficient for all known use cases. - Fix scaling from 16bit down to 12bit for the rkisp1. - Add more documentation text and (hopefully) clarify some commit messages. - Reworked the tuning data handling as proposed by Laurent. - Updated all tuning files that contained black level values. Changes in v3: - Fixed incorrect shift direction in P3/6 - Added missing docs for blackLevel_ - Added comments to the black level values - Fixed some typos and review suggestions Stefan Klug (6): ipa: libipa: Add black levels to camera sensor helper ipa: rkisp1: Move camHelper into IPAContext ipa: rkisp1: blc: Query black levels from camera sensor helper ipa: rkisp1: blc: Report sensor black levels in metadata ipa: rkisp1: data: Update tuning files for imx219 and imx258 ipa: rkisp1: Move ov4689 and ov5640 black levels into sensor helpers src/ipa/libipa/camera_sensor_helper.cpp | 42 +++++++++++++ src/ipa/libipa/camera_sensor_helper.h | 3 + src/ipa/rkisp1/algorithms/blc.cpp | 82 ++++++++++++++++++++++--- src/ipa/rkisp1/algorithms/blc.h | 5 +- src/ipa/rkisp1/data/imx219.yaml | 4 -- src/ipa/rkisp1/data/imx258.yaml | 1 + src/ipa/rkisp1/data/ov4689.yaml | 4 -- src/ipa/rkisp1/data/ov5640.yaml | 4 -- src/ipa/rkisp1/data/uncalibrated.yaml | 1 + src/ipa/rkisp1/ipa_context.h | 6 ++ src/ipa/rkisp1/rkisp1.cpp | 26 ++++---- 11 files changed, 143 insertions(+), 35 deletions(-)