From patchwork Mon Jun 24 19:29:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 20367 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A2C15BD87C for ; Mon, 24 Jun 2024 19:30:06 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9B004654AA; Mon, 24 Jun 2024 21:30:05 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="H6fNwFPH"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F117654A1 for ; Mon, 24 Jun 2024 21:30:04 +0200 (CEST) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DBEAE1650; Mon, 24 Jun 2024 21:29:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1719257382; bh=0E7vTCHfBVrAl4B+sCq9xjPgULhG1JWLx0s0Is+dw7g=; h=From:To:Cc:Subject:Date:From; b=H6fNwFPHpnN1aaM4IUYlL+Vv44C7II6Jw5hs2B5APYJIT2dqPy/wunIygqVP9qMJE 9pFM3+iumGCH98fEmG+/Yu21jLlrL7ZkiPpdAvfJHmmwUzJ843vWV6nQSLTOfguToP TXWYQis2CYVQW3c021R9xL0QLTDwK485ASce/wAE= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Cc: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= Subject: [PATCH 00/10] libcamera: Enable -Wmissing-declarations Date: Mon, 24 Jun 2024 22:29:31 +0300 Message-ID: <20240624192941.22943-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.44.2 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, This patch series enables -Wmissing-declarations to catch mismatches between function declarations and definitions, which recently introduced a bug in libcamera. Patch 01/10 to 09/10 first fix a (surprisingly large) number of offenders that trigger the warning, and patch 10/10 the enables it. Laurent Pinchart (10): libcamera: base: log: Declare log categories when defining them ipa: ipa_interface: Declare ipaCreate() in libcamera namespace ipa: rpi: Define local functions in anonymous namespace py: libcamera: Move function declarations to common header v4l2: v4l2_compat: Include missing headers v4l2: v4l2_compat: Selectively disable -Wmissing-declarations apps: Define local functions in anonymous namespace test: ipc: unixsocket: Define local function in anonymous namespace test: gstreamer: Include missing sanitizer/asan_interface.h header meson: Enable warnings to flag missing declarations include/libcamera/base/log.h | 1 + include/libcamera/ipa/ipa_interface.h | 4 +- meson.build | 1 + src/apps/cam/main.cpp | 4 ++ src/apps/common/dng_writer.cpp | 6 ++- src/apps/qcam/main.cpp | 4 ++ src/ipa/rpi/controller/rpi/ccm.cpp | 6 ++- src/ipa/rpi/controller/rpi/contrast.cpp | 4 ++ src/py/libcamera/py_color_space.cpp | 2 + src/py/libcamera/py_controls_generated.cpp.in | 2 + src/py/libcamera/py_enums.cpp | 2 + src/py/libcamera/py_formats_generated.cpp.in | 2 + src/py/libcamera/py_geometry.cpp | 2 + src/py/libcamera/py_main.cpp | 8 ---- src/py/libcamera/py_main.h | 10 +++++ .../libcamera/py_properties_generated.cpp.in | 2 + src/py/libcamera/py_transform.cpp | 2 + src/v4l2/v4l2_compat.cpp | 45 ++++++++++++------- test/gstreamer/gstreamer_test.cpp | 6 +++ test/gstreamer/meson.build | 7 +++ test/ipc/unixsocket.cpp | 4 ++ 21 files changed, 95 insertions(+), 29 deletions(-) base-commit: 2119bdac6a011034cc33584e3303e47db4932313