From patchwork Mon Jun 24 13:48:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 20362 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 95DB1BD87C for ; Mon, 24 Jun 2024 13:49:16 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6CE8B654AA; Mon, 24 Jun 2024 15:49:15 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="X/+8DFre"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0CD45654A1 for ; Mon, 24 Jun 2024 15:49:14 +0200 (CEST) Received: from fedora.local (unknown [IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 758917E0; Mon, 24 Jun 2024 15:48:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1719236932; bh=a2AtqDOSGSRlihyt38xMu0ak6m3Y447vB4UuVHMistY=; h=From:To:Cc:Subject:Date:From; b=X/+8DFreuuSQ2X7VCusAV1VgR7HgbTjXvvmm2DH7x+NfO9gGTl3oOS8JYTXxOCQGK DR8timB5TBbePozesF9kOAKe3kxhi749BKGCrJy6vznqN25+TnFpJkl5mq6PFH7Xil I5GskC9PbJsAxDqfx+C5PRHYJBm7+pnpVcWzocwo= From: Umang Jain To: libcamera-devel@lists.libcamera.org Cc: Umang Jain Subject: [PATCH v4 0/4] libcamera: converter: Replace usage of stream index by Stream pointer Date: Mon, 24 Jun 2024 19:18:55 +0530 Message-ID: <20240624134859.171969-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The v4l2_converter_m2m and simple pipeline handler are adapt to use the new interface. This work roped in software ISP as well, which also seems to use indexes (although it doesn't implement converter interface) because of a common conversionQueue_ queue used for converter_ and swIsp_. Patch 1/4 and 2/4 drop redundant validation of outputs std::map<>. Patch 3/4 renames private class V4L2M2MConverter::Stream to V4L2M2Mconverter::V4L2M2MStream Patch 4/4 replaces the stream index usage from converter interface and soft isp. Tested-by: Andrei Konovalov # sm8250 RB5 --- Tested with mxc-isi running software isp on i.MX8MP platform --- changes in v4: - Emplace V4L2M2MStream stream only after configure() succeeds. (trivial shuffle of ordering of the call). - Collect R-b tags Changes in v3: - Fix issue while running soft-isp - Fix missing Doxygen changes changes in v2: - Split out patches 1/4 and 2/4 to tackle validation/sanity check - Rename V4L2M2MConverter::Stream to V4L2M2Mconverter::V4L2M2MStream Umang Jain (4): converter: converter_v4l2_m2m: Rectify streams sanity check libcamera: software_isp: Drop unnecessary sanity check converter: converter_v4l2_m2m: Rename private Stream class libcamera: converter: Replace usage of stream index by Stream pointer include/libcamera/internal/converter.h | 5 +- .../internal/converter/converter_v4l2_m2m.h | 13 +-- .../internal/software_isp/software_isp.h | 5 +- src/libcamera/converter.cpp | 6 +- .../converter/converter_v4l2_m2m.cpp | 79 ++++++++++--------- src/libcamera/pipeline/simple/simple.cpp | 14 ++-- src/libcamera/software_isp/software_isp.cpp | 26 +++--- 7 files changed, 73 insertions(+), 75 deletions(-)