From patchwork Sun Jun 16 16:38:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 20328 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 70806C3237 for ; Sun, 16 Jun 2024 16:39:35 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4133E6548E; Sun, 16 Jun 2024 18:39:34 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="HnFAnUvc"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id F297865456 for ; Sun, 16 Jun 2024 18:39:31 +0200 (CEST) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6DD4E581 for ; Sun, 16 Jun 2024 18:39:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1718555955; bh=yOHKUa9IR3ZnddQjElsgUBCNZbWIeg3rF5p1uU7uiJk=; h=From:To:Subject:Date:From; b=HnFAnUvcAMKLa6xb/OXUc1x4vmbqzTM/eQyIXeHUWJkytm/5zObTgV3H/oqJJ2+7L 8i4EXki83dPKdDUqKvRwUkwpvvSSiMN5j2PbtbXrkRoKUP1rE+d65CnkxcpCM5R5GJ BNPolTxjLmw4Sbwzh1S40XNl5fXvQNThlz8oDlbk= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Subject: [PATCH 00/12] ipa: rkisp1: Miscellaneous AGC fixes Date: Sun, 16 Jun 2024 19:38:58 +0300 Message-ID: <20240616163910.5506-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.44.2 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, This patch series contains a set of assorted AGC fixes and enhancements for the rkisp1, as well as the agc_mean_luminance helper. Patch 01/12 fixes a regression in the recently merged histogram weights support. It should be fast-tracked, as the master branch is currently broken for users who don't have AE metering modes in their tuning file. There's not much else to be said about the series here, please see individual patches for details. Laurent Pinchart (12): ipa: rkisp1: agc: Fix initialization without metering modes ipa: libipa: agc_mean_luminance: Fix enumerator names ipa: libipa: agc_mean_luminance: Include missing header ipa: rkisp1: Document all AGC parameters in IPAActiveState ipa: rkisp1: Document all AGC parameters in IPAFrameContext ipa: rkisp1: agc: Make size argument to computeHistogramPredivider const ipa: rkisp1: agc: Don't update histogram parameters unnecessarily ipa: rkisp1: agc: Simplify predivider calculation ipa: rkisp1: agc: Use mode from frame context to calculate new EV ipa: rkisp1: agc: Rename maxShutterSpeed to maxFrameDuration ipa: rkisp1: agc: Correctly clamp maximum shutter speed ipa: rkisp1: agc: Move AeEnable control to the AGC algorithm src/ipa/libipa/agc_mean_luminance.cpp | 10 ++--- src/ipa/libipa/agc_mean_luminance.h | 6 ++- src/ipa/rkisp1/algorithms/agc.cpp | 44 ++++++++----------- src/ipa/rkisp1/algorithms/agc.h | 2 +- src/ipa/rkisp1/ipa_context.cpp | 62 ++++++++++++++++++++++++--- src/ipa/rkisp1/ipa_context.h | 4 +- src/ipa/rkisp1/rkisp1.cpp | 1 - 7 files changed, 85 insertions(+), 44 deletions(-) base-commit: d978832d9e987b555be7c0ee8eeda37981924515