From patchwork Wed Jun 5 09:53:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 20205 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0F651BDE6B for ; Wed, 5 Jun 2024 09:54:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CAC8F634DB; Wed, 5 Jun 2024 11:54:25 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="JS/Q8nGd"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BB0C7634B5 for ; Wed, 5 Jun 2024 11:54:23 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:dcc4:f2dc:93ce:ff8f]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 36F9714B0; Wed, 5 Jun 2024 11:54:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1717581255; bh=3SEPFWv8tq/NDarOu3qPQCZQQyBXH81Wlaeoxrw8F6Q=; h=From:To:Cc:Subject:Date:From; b=JS/Q8nGdcY4bllUq+oFBW04b4Gv4pRty/24emTP28rM0lda1OmkLv8LYMANWfN+E3 IjWyG8ZGyR3s73L1Ss/tceFKXIQTUVfG3qTpYI86tVYT7o0UZY/Kd8m2m/UP/vWZ2W ev5s8OCq7r86A/djo27jhF20ZCAkt4kDUci20e5o= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v4 0/3] libcamera: Add gamma control for rkisp1 Date: Wed, 5 Jun 2024 11:53:48 +0200 Message-ID: <20240605095417.157703-1-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This patchset adds a gamma algorithm and the corresponding control for rkisp1. A camera gamma of roughly 2.2 is necessary to produce correct output images on a standard monitor and to comply with sRGB. Further information is available here: https://en.wikipedia.org/wiki/SRGB https://www.cambridgeincolour.com/tutorials/gamma-correction.htm v3 -> v4: - Changed structure in IPAActiveState and IPAFrameContext to be in line with the other algorithms. v2 -> v3: - Renamed the algorithm to GammaOutCorrection which seems to be more in line with the other algorithms. (This got clearer to me after writing the schema file) - Added ability to configure the default gamma value in the tuning file - Squashed patch 1/4 and 4/4 to make it easier to review - Applied feedback from reviews v1 -> v2: - Fixed some stylistic issues from review - Added gamma control only if algorithm is present Stefan Klug (3): libcamera: Add gamma control id ipa: rkisp1: Fix algorithm controls vanish after configure ipa: rkisp1: Add GammaOutCorrection algorithm src/ipa/rkisp1/algorithms/goc.cpp | 153 ++++++++++++++++++++++++++ src/ipa/rkisp1/algorithms/goc.h | 42 +++++++ src/ipa/rkisp1/algorithms/meson.build | 1 + src/ipa/rkisp1/ipa_context.h | 9 ++ src/ipa/rkisp1/rkisp1.cpp | 2 +- src/libcamera/control_ids_core.yaml | 7 ++ 6 files changed, 213 insertions(+), 1 deletion(-) create mode 100644 src/ipa/rkisp1/algorithms/goc.cpp create mode 100644 src/ipa/rkisp1/algorithms/goc.h