From patchwork Fri May 17 08:07:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 20061 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 86FA5BD78E for ; Fri, 17 May 2024 08:08:12 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 715CB6347E; Fri, 17 May 2024 10:08:11 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="a7VY+Kmh"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1ACDA61A5A for ; Fri, 17 May 2024 10:08:10 +0200 (CEST) Received: from neptunite.hamster-moth.ts.net (h175-177-049-156.catv02.itscom.jp [175.177.49.156]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 03F9B512; Fri, 17 May 2024 10:07:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1715933281; bh=gxF677WVY3e1STmVTefVfVkVUbXkhEYeh1BtuliEA+4=; h=From:To:Cc:Subject:Date:From; b=a7VY+KmhXedgkMytk5HuV+Qc6mq0p4hAVQDMHu5qizRor2sws7ndGtRrDr66oU0MU pk7bRbrfqS9/VXU+de2IaeusURTJ8kjo5bwnKEv/hkZEuvI+PKpBpOBSYFe2WA+ZUG 5lO2gdP0VCIR2AKOjejIjnIY4ALGDqhioDUOAsns= From: Paul Elder To: libcamera-devel@lists.libcamera.org Cc: Paul Elder Subject: [PATCH v3 0/3] ipa: rkisp1: Improve AGC (plumbing) Date: Fri, 17 May 2024 17:07:58 +0900 Message-Id: <20240517080802.3896531-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This series depends on v2 of the series "ipa: Move Pwl from Raspberry Pi to libipa". This series adds support in the rkisp1 IPA for: - reading histogram weights (metering modes) from tuning file - expands luminance target from a scalar value to piecewise linear function, controlled by lux - plumbs controls for setting metering mode, exposure mode, constraint mode, and frame duration As of v2, defaults have been added such that the rkisp1 pipeline will no longer break with non-existent/erroneous tuning files. v3 mainly adds support for both v10 and v12, and fixes a limits issue in when using the exposure mode helper. Paul Elder (3): ipa: rkisp1: agc: Read histogram weights from tuning file ipa: libipa: agc: Change luminance target to piecewise linear function ipa: rkisp1: agc: Plumb mode-selection and frame duration controls src/ipa/ipu3/algorithms/agc.cpp | 5 +- src/ipa/libipa/agc_mean_luminance.cpp | 31 ++++-- src/ipa/libipa/agc_mean_luminance.h | 7 +- src/ipa/rkisp1/algorithms/agc.cpp | 146 +++++++++++++++++++++++++- src/ipa/rkisp1/algorithms/agc.h | 6 ++ src/ipa/rkisp1/algorithms/algorithm.h | 2 + src/ipa/rkisp1/ipa_context.h | 10 +- src/ipa/rkisp1/rkisp1.cpp | 10 ++ 8 files changed, 199 insertions(+), 18 deletions(-)