From patchwork Tue Apr 23 18:19:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Milan Zamazal X-Patchwork-Id: 19929 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C6000BE08B for ; Tue, 23 Apr 2024 18:20:16 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 09BA961AC1; Tue, 23 Apr 2024 20:20:16 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="aBLWmpnN"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3DD5361AC1 for ; Tue, 23 Apr 2024 20:20:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713896413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JGKCXtB4xVLC5PJVJDFr78ycFFWX5DI61s7/xavFFgs=; b=aBLWmpnNzZ6hnyOHyjTjWH8hpCIR7RbD77jclnPKj24w+IG6tAP6Gtag11KeEX+dR7JAXw 9M7Ezfb7TB8lTqLhgrPUxBr7AoyWw6F1/4CDqJxbJR0K0DZkCfGOo1cY2/ChVqVJOr4lmO Y53CoufDHh6cAnC/TjU6UAA136Kvz8Y= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-193-jSb7qDuENHOHNmkQO76NtA-1; Tue, 23 Apr 2024 14:20:11 -0400 X-MC-Unique: jSb7qDuENHOHNmkQO76NtA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2D2181C05AA0 for ; Tue, 23 Apr 2024 18:20:11 +0000 (UTC) Received: from nuthatch.redhat.com (unknown [10.45.225.63]) by smtp.corp.redhat.com (Postfix) with ESMTP id 55534151EF; Tue, 23 Apr 2024 18:20:10 +0000 (UTC) From: Milan Zamazal To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal Subject: [PATCH 0/5] Software ISP levels cleanup Date: Tue, 23 Apr 2024 20:19:55 +0200 Message-ID: <20240423182000.1527425-1-mzamazal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This is a cleanup of black level and color gain handling in software ISP. It fixes omission of black level subtraction in white balance computation and moves color lookup tables computations out of debayering. The latter also serves as a preparation for bringing software ISP algorithms closer to common libcamera algorithm handling, in future patches. Milan Zamazal (5): libcamera: software_isp: Use a specific integer type for black level libcamera: software_isp: Honor black level in AWB libcamera: software_isp: Move color mappings out of debayering libcamera: software_isp: Remove TODO #13 libcamera: software_isp: Remove DebayerParams::kGain10 .../internal/software_isp/debayer_params.h | 19 ++-- src/ipa/simple/black_level.cpp | 3 +- src/ipa/simple/black_level.h | 4 +- src/ipa/simple/soft_simple.cpp | 86 +++++++++++++++---- src/libcamera/software_isp/TODO | 23 ----- src/libcamera/software_isp/debayer.cpp | 28 +++--- src/libcamera/software_isp/debayer_cpu.cpp | 41 ++------- src/libcamera/software_isp/debayer_cpu.h | 9 +- src/libcamera/software_isp/software_isp.cpp | 4 +- 9 files changed, 103 insertions(+), 114 deletions(-)