From patchwork Tue Mar 19 10:54:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 19737 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 042C2BD160 for ; Tue, 19 Mar 2024 10:54:30 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0D68D62CAA; Tue, 19 Mar 2024 11:54:30 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="uWuXri/g"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F5DB61C61 for ; Tue, 19 Mar 2024 11:54:28 +0100 (CET) Received: from pyrite.hamster-moth.ts.net (h175-177-049-156.catv02.itscom.jp [175.177.49.156]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 39D02480; Tue, 19 Mar 2024 11:53:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1710845641; bh=Kua3xTlZq8tPxnaGhXQLMQn6XUNJMSKrxTxeJ2CX760=; h=From:To:Cc:Subject:Date:From; b=uWuXri/gFphI9PBgF5mJfmzkKmq+1k5dslvLpB9Yta1XVnkcw3oM9eaK2kJBsgRf6 i/uCqVJp1RwhSvI3QaarVLnhxeMzaZBaQ8MN0rU8KlfMPiAGprlEIr0W9FxDwsl7YE ecGtOJlaWroJtTt+tZG9ZFsD90Wb3RzNVAfhAg3Q= From: Paul Elder To: libcamera-devel@lists.libcamera.org Cc: Paul Elder Subject: [PATCH 0/2] ipa: rkisp1: Fix histogram Date: Tue, 19 Mar 2024 19:54:01 +0900 Message-Id: <20240319105403.4045592-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This patch series fixes the histogram usage for rkisp1. The lower 4 bits should be ignored. Personally I feel like this should be fixed in the kernel... but I have a feeling it would count as a uapi change and be rejected so we're fixing it here in libcamera instead. Paul Elder (2): ipa: libipa: histogram: Add rshift parameter to constructor ipa: rkisp1: agc: Fix histogram construction src/ipa/libipa/histogram.cpp | 5 +++-- src/ipa/libipa/histogram.h | 2 +- src/ipa/rkisp1/algorithms/agc.cpp | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-)