From patchwork Wed Mar 13 10:56:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 19688 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 955F8BD1F1 for ; Wed, 13 Mar 2024 10:56:56 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4321E62C96; Wed, 13 Mar 2024 11:56:55 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="n5MZvyzK"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 94D3A6294A for ; Wed, 13 Mar 2024 11:56:52 +0100 (CET) Received: from jasper.fritz.box (unknown [IPv6:2a00:6020:448c:6c00:9b07:31b5:38e1:e957]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0AB5B899; Wed, 13 Mar 2024 11:56:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1710327390; bh=+iH3gnSjt9slOdqRkoUDHuziQm8yP5drUqmtrF91ZoA=; h=From:To:Cc:Subject:Date:From; b=n5MZvyzKGC8QJMLhKTNCez8kK6PZq9Oga7A4DXC/RqPmtjP6qMxyTURT7WtqLid9W QzOqda47RsfW7TF6XyTpfryJZabh71r81Jo+dy8HV7G18r3kdiHTaPIjEBy5J0pjgP G6Q5JW1TfU0cDIZZ3yZUAiOQSilLuipRfG6Odh6Q= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Subject: [PATCH 00/12] Preparation for per-frame-controls and initial tests Date: Wed, 13 Mar 2024 11:56:32 +0100 Message-Id: <20240313105645.120317-1-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi everyone, unknowingly I stumbled into a topic that is way larger than I thought in the beginning. Delayed-controls and a closely related topic per-frame-controls. I (now) know that a lot of work already went into this, noteably by Jacopo Mondi, David Plowman and Naushir Patuck: https://patchwork.libcamera.org/cover/16458/ https://github.com/raspberrypi/libcamera/tree/pfc Thanks for that! I started off without per-frame-controls in mind (only delayed-controls) and soon realized, that these two are closely related. (It's difficult to test delayed-controls in a real pipeline without working per-frame-controls) To be able to tackle the whole topic in the long run I'd like to split it into parts: 1. Get a initial set of tests on mainline I'd like to have them as a discussion basis and a reference to test against. These shouldn't be treated as mandatory for now (ideas on how to express that in code are very welcome) - Initial lc-compliance tests for delayed-controls (and because these are system tests also for per-frame-controls) - A reworked delayed controls class that hopefully makes things easier - Tested on rkisp1 (details see below) 2. Get an agreement on "RaspberryPi" mode In the previous work by David and Naushir, the (in my understanding) most prominent requiremnet was the ability to set a control ASAP even when multiple requests are queued already (which makes complete sense IMHO). This requirement shall not get lost and I think there is a way to make it work. 3. Get the tests to pass on rkisp1, rpi and ipu3 I guess this will take a while and involve different parties, so let's not wait until everything works everywhere... 4. Make the tests mandatory (details tbd) This series contains part 1. One change of thought is, that we add the ability to push requests to delayed controls for a given sequence number and to re-push for the same sequence number. This has the benefit, that we don't have to decide early on if we operate in strict per-frame-controls mode (sometimes called "android mode") or in "raspberry pi" mode. Stefan Klug (12): libcamera: lc-compliance: Add controls param to start() function libcamera: lc-compliance: Add TimeSheet class libcamera: lc-compliance: Add initial set of per-frame-control tests libcamera: delayed_controls: Update unit tests to expected semantics libcamera: delayed_controls: Rename class members libcamera: delayed_controls: Rework delayed controls implementation libcamera: delayed_controls: Add some logging libcamera: delayed_controls: Add ctrls list parameter to reset() function pipeline: rkisp1: Move call to setSensorControls.emit() pipeline: rkisp1: Add more debug logging pipeline: rkisp1: Fix per-frame-controls in manual mode pipeline: rkisp1: Apply initial controls include/libcamera/internal/delayed_controls.h | 20 +- include/libcamera/ipa/rkisp1.mojom | 7 +- src/apps/lc-compliance/capture_test.cpp | 46 +++ src/apps/lc-compliance/meson.build | 2 + src/apps/lc-compliance/per_frame_controls.cpp | 316 ++++++++++++++++++ src/apps/lc-compliance/per_frame_controls.h | 43 +++ src/apps/lc-compliance/simple_capture.cpp | 4 +- src/apps/lc-compliance/simple_capture.h | 2 +- src/apps/lc-compliance/time_sheet.cpp | 145 ++++++++ src/apps/lc-compliance/time_sheet.h | 55 +++ src/ipa/rkisp1/algorithms/agc.cpp | 4 +- src/ipa/rkisp1/rkisp1.cpp | 49 ++- src/libcamera/delayed_controls.cpp | 235 ++++++++++--- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 11 +- test/delayed_controls.cpp | 203 ++++++++--- 15 files changed, 1021 insertions(+), 121 deletions(-) create mode 100644 src/apps/lc-compliance/per_frame_controls.cpp create mode 100644 src/apps/lc-compliance/per_frame_controls.h create mode 100644 src/apps/lc-compliance/time_sheet.cpp create mode 100644 src/apps/lc-compliance/time_sheet.h