From patchwork Mon Mar 11 12:32:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 19656 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A93D1BD1F1 for ; Mon, 11 Mar 2024 12:32:46 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B951262C88; Mon, 11 Mar 2024 13:32:45 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="OUBI+BSZ"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B29D61C7C for ; Mon, 11 Mar 2024 13:32:44 +0100 (CET) Received: from localhost.localdomain (93-61-96-190.ip145.fastwebnet.it [93.61.96.190]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1F9D6C85; Mon, 11 Mar 2024 13:32:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1710160343; bh=UvS7UH3thTTr1V2bXuQ82vfckUda1WGvtLfDlItBx+g=; h=From:To:Cc:Subject:Date:From; b=OUBI+BSZRXHiV2tTYDmMx3gQ2YPVHOIJc8lzq5o8H95/aQyORR8QtdWtgSlrwVWdS w4DO3sxHmBZS0g9YtRg/HYxZWMCDlZyKh8Cc5fkTPsqLlWonoI7hF/GvNiv/3+TL+1 qheb7RUhDJWlafwLDkceuxE3fj4is/HocOUlL5e0= From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Subject: [PATCH v2 0/4] libcamera: Replace IPU3/RkISP1FrameInfo Date: Mon, 11 Mar 2024 13:32:28 +0100 Message-ID: <20240311123234.32925-1-jacopo.mondi@ideasonboard.com> X-Mailer: git-send-email 2.43.2 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jacopo Mondi Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" v1->v2: - Squash patches 2 and 3 in a single one - Maintain the existing behaviour for queueing RAW frames to the RkISP1 IPA - Minor changes to the IPU3 patch as suggested by Dan Pipeline: https://gitlab.freedesktop.org/pinchartl/libcamera/-/pipelines/1124683 The RkISP1 and IPU3 pipeline have custom classes that provide the following features: - Associate a stat, params and (optionally) a raw buffer with the id used to communicate between the pipeline handler and the IPA - Associate a completed buffer with the Request it belongs to The same functionalities can be obtained by extending the Request::Private class with a per-pipeline derived implementation that tracks buffers and ids reducing code duplications. Jacopo Mondi (4): libcamera: Allow pipeline to provide a Private request libcamera: rkisp1: Replace usage of RkISP1FrameInfo libcamera: ipu3: Replace IPU3FrameInfo libcamera: ipu3: Return Raw buffers on error include/libcamera/internal/pipeline_handler.h | 5 +- include/libcamera/request.h | 3 +- src/libcamera/camera.cpp | 8 +- src/libcamera/pipeline/ipu3/frames.cpp | 143 ------- src/libcamera/pipeline/ipu3/frames.h | 67 ---- src/libcamera/pipeline/ipu3/ipu3.cpp | 215 +++++++---- src/libcamera/pipeline/ipu3/meson.build | 1 - src/libcamera/pipeline/rkisp1/rkisp1.cpp | 359 +++++++----------- src/libcamera/pipeline_handler.cpp | 38 +- src/libcamera/request.cpp | 15 +- test/camera/statemachine.cpp | 12 - 11 files changed, 328 insertions(+), 538 deletions(-) delete mode 100644 src/libcamera/pipeline/ipu3/frames.cpp delete mode 100644 src/libcamera/pipeline/ipu3/frames.h --- 2.43.2