From patchwork Wed Feb 21 17:40:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 19522 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 42994C0F1B for ; Wed, 21 Feb 2024 17:40:30 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 728D462820; Wed, 21 Feb 2024 18:40:29 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="cyxQd6Bq"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E22261C9D for ; Wed, 21 Feb 2024 18:40:27 +0100 (CET) Received: from localhost.localdomain (unknown [IPv6:2001:b07:5d2e:52c9:cc1e:e404:491f:e6ea]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5A88F2B3; Wed, 21 Feb 2024 18:40:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1708537219; bh=Kyyjo/IEHiaJYN8A98vKNGfi1WvAzLBmXFdjeZA/NUg=; h=From:To:Cc:Subject:Date:From; b=cyxQd6Bqk5dA1da6LnYUO1lKS8dkvu0UkEitDl83xAJlZ+1Ko0pCA5SNGLjGAL8Rn uDQwaY9FvMXZOW3KQs5QXJTf1Rq5cJp5NzInYKaYBuK2RjV0tZsIqp0h6/T6iKNICG vtne/LT0a++lE3fBV0nHdVuv37bCOTQO6/HQpUbE= From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Subject: [PATCH 0/5] libcamera: Replace IPU3/RkISP1FrameInfo Date: Wed, 21 Feb 2024 18:40:08 +0100 Message-ID: <20240221174015.52958-1-jacopo.mondi@ideasonboard.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jacopo Mondi Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The RkISP1 and IPU3 pipeline have custom classes that provide the following features: - Associate a stat, params and (optionally) a raw buffer with the id used to communicate between the pipeline handler and the IPA - Associate a completed buffer with the Request it belongs to The same functionalities can be obtained by extending the Request::Private class with a per-pipeline derived implementation that tracks buffers and ids reducing code duplications. Jacopo Mondi (5): libcamera: Allow pipeline to provide a Private request libcamera: rkisp1: Create a request with a custom private class libcamera: rkisp1: Replace usage of RkISP1FrameInfo libcamera: ipu3: Replace IPU3FrameInfo libcamera: ipu3: Return Raw buffers on error include/libcamera/internal/pipeline_handler.h | 5 +- include/libcamera/request.h | 3 +- src/libcamera/camera.cpp | 8 +- src/libcamera/pipeline/ipu3/frames.cpp | 143 ------- src/libcamera/pipeline/ipu3/frames.h | 67 ---- src/libcamera/pipeline/ipu3/ipu3.cpp | 224 +++++++---- src/libcamera/pipeline/ipu3/meson.build | 1 - src/libcamera/pipeline/rkisp1/rkisp1.cpp | 359 +++++++----------- src/libcamera/pipeline_handler.cpp | 38 +- src/libcamera/request.cpp | 15 +- 10 files changed, 337 insertions(+), 526 deletions(-) delete mode 100644 src/libcamera/pipeline/ipu3/frames.cpp delete mode 100644 src/libcamera/pipeline/ipu3/frames.h --- 2.43.0