From patchwork Mon Feb 12 15:35:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Scally X-Patchwork-Id: 19477 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B647DBDE17 for ; Mon, 12 Feb 2024 15:35:45 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id DC66262807; Mon, 12 Feb 2024 16:35:44 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Fp4b7QaY"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7500A61CB6 for ; Mon, 12 Feb 2024 16:35:43 +0100 (CET) Received: from mail.ideasonboard.com (cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B5FE2D8; Mon, 12 Feb 2024 16:35:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1707752141; bh=4GHKDGusIwVaM05g22b85HXhcK/Lj8qo+ILzaWKGSKU=; h=From:To:Cc:Subject:Date:From; b=Fp4b7QaY3Lb2u5AxQg3cqfgrIgpvf4+X4Zvljzz8B74rVIr7Tr6oUTsy3OKgrzVEx xVCgL5rTcbOzRj3/lLgQ7UqVkuAmhE16cFicXMQ2S8eLjG/H5zxvHJu9LTsMr9Pmhy +4NC0nKvjqh8gqfchuSe8XPUSB6Vqij4rtT50KOc= From: Daniel Scally To: libcamera-devel@lists.libcamera.org Subject: [PATCH 0/5] Remove RkISP1FrameInfo class Date: Mon, 12 Feb 2024 15:35:27 +0000 Message-Id: <20240212153532.179283-1-dan.scally@ideasonboard.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello all The RkISP1FrameInfo class exists (at least so far as I understand things) to keep track of when a Request can be completed by tracking the status of the video, stats and parameters buffers. I don't see that the class is really necessary for the job, so this series represents an attempt at removing it and re-factoring the functionality of its methods out to elsewhere in the pipeline handler. Thanks Dan Daniel Scally (5): libcamera: rkisp1: Make tryCompleteRequest() params agnostic libcamera: rkisp1: Standardise frame number tracking libcamera: rkisp1: Switch IPA slots to use bufferId not frame libcamera: rkisp1: Switch tryCompleteRequest() to use Request * libcamera: rkisp1: Remove RkISP1FrameInfo include/libcamera/ipa/rkisp1.mojom | 4 +- src/ipa/rkisp1/rkisp1.cpp | 4 +- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 327 ++++++----------------- 3 files changed, 91 insertions(+), 244 deletions(-)