From patchwork Tue Jan 30 18:13:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 19469 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id ADB3ABDCBF for ; Tue, 30 Jan 2024 18:13:21 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3A3BE62134; Tue, 30 Jan 2024 19:13:20 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="WNSXbZ3x"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7457660983 for ; Tue, 30 Jan 2024 19:13:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706638397; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PF2LSRNUEStxyz0Ok+W4aAUuYFksmvpw1mltmQ+h3ss=; b=WNSXbZ3xIQe9XKJIUODoMyJmIWPvryQ42bgd896rH1JR6xMOZ5svsoJ2Mh3fAk+rsbK8x9 QDk/kwl5KM5Ux7PuNU7yqLSTHDmkEXOMd5dKrc6u1bEkK/hL/qSK+5qVaclKIRpOB2KEUQ dBZSJ6l87a1WsoTX3jgNTWuI4/l//5k= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-580-Bkei4LaSOUKq0-v74LmzuQ-1; Tue, 30 Jan 2024 13:13:13 -0500 X-MC-Unique: Bkei4LaSOUKq0-v74LmzuQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2B3761064C67; Tue, 30 Jan 2024 18:13:13 +0000 (UTC) Received: from shalem.redhat.com (unknown [10.39.192.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2788E40C122E; Tue, 30 Jan 2024 18:13:12 +0000 (UTC) From: Hans de Goede To: libcamera-devel@lists.libcamera.org Subject: [RFC 0/2] libcamera: debayer_cpu: Stop requiring 2 lines of padding at the top/bottom Date: Tue, 30 Jan 2024 19:13:09 +0100 Message-ID: <20240130181311.43745-1-hdegoede@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Pavel Machek , Bryan O'Donoghue Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi All, Note this series is just FYI / a headsup about this small(ish?) change to the SoftISP debayer code. I plan to squash this into v3 of the SoftISP series. Since the standard bayer pattern debayer functions now take an array of 3 src pointers (previous-, current- and next-line) we can easily avoid the need to have 2 lines (2 to keep the pattern unchanged) padding at the top / bottom. This allows the output to be 4 lines higher, which is esp. useful with the current hi556 kernel driver which has a max-height for the bauer data of 722 lines. So before this change it was not possible to generate a standard 1280x720 output. Regards, Hans Hans de Goede (2): libcamera: debayer: Move sizes() to DebayerCpu implementation libcamera: debayer_cpu: Stop requiring 2 lines of padding at the top/bottom .../libcamera/internal/software_isp/debayer.h | 26 +----- .../internal/software_isp/debayer_cpu.h | 4 +- src/libcamera/software_isp/debayer_cpu.cpp | 90 +++++++++++++++++-- 3 files changed, 86 insertions(+), 34 deletions(-)