From patchwork Sat Dec 23 11:10:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 19344 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CF610BDB1D for ; Sat, 23 Dec 2023 11:10:37 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 02B7A62B54; Sat, 23 Dec 2023 12:10:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1703329837; bh=3jKsAd9y71DeeP9OyfgdAoC54ctiqPjehxXa7k1aqRs=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=fsp+5WLpWs74mhEi1rXAZKe1j4SL/6y8ED0seXqCjegXQAYgbSSUMs0Kqcyj68DwH yFTJgKMAd9ZMhvl1InYiqDO1jSxyNTrNsMIK4Bxhpr2izBYivSmyVsKhctoC3wcx+s 8lWkI6iN0+FCXQYTN1PWttyfFefLMsur1QA67CXEHx5HPhi/WEYM6tNEbku7KGXFNH LPMXyw1IY68cKbfjRxjRdIWCwmQdyHOD4TVRbLuZOo2sPNVr+eWRef2g0fkBUb1Fvy ZPgybwqBOUFq2pKveIC94vIWaDJeqevkzH+HjB1aNd4ciI8znMA+PeClbsHIHJMxMU M3L+DSJfa2CXQ== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F19961D8E for ; Sat, 23 Dec 2023 12:10:35 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ov4gLC66"; dkim-atps=neutral Received: from localhost.localdomain (93-61-96-190.ip145.fastwebnet.it [93.61.96.190]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BB6029A8; Sat, 23 Dec 2023 12:09:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1703329782; bh=3jKsAd9y71DeeP9OyfgdAoC54ctiqPjehxXa7k1aqRs=; h=From:To:Cc:Subject:Date:From; b=ov4gLC66Hsg4RBZ61Ul+9IgLfC5/6zrnww2XW59xBwvDuc/qT6r2X2rn2p5bmwsA/ DVbRpSIucHkofN5VJBiIdSpmbYLWc9KLY+kdX+ZBdFirXjcG/EVRDEfuF02uI1fp9w xWq0UmiC27ml7muPnEfpTDgY0H+JVUEYiAtx+vOI= To: libcamera-devel@lists.libcamera.org Date: Sat, 23 Dec 2023 12:10:18 +0100 Message-ID: <20231223111023.668199-1-jacopo.mondi@ideasonboard.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/5] apps: lc-compliance: Add controls and properties test X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jacopo Mondi via libcamera-devel From: Jacopo Mondi Reply-To: Jacopo Mondi Cc: Jacopo Mondi Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" v2->v1: - I forgot to move the newly added test in the test/ subdir Add a test case to validate that mandatory properties and controls are registered by a Camera. Before adding a new test, a little refresh of the lc-compliance sources might help. I collected patches from the list for a few minor fixes and re-organized the source tree by splitting helpers/ and tests/ in dedicated sub-directory. Finally, add a test for controls and properties. The series is based on "[PATCH 0/2] libcamera: Add support for required controls" on which the test depends. Thanks j Jacopo Mondi (3): apps: lc-compliance: Fix typo in comment apps: lc-compliance: Re-organize source directory apps: lc-compliance: Test for mandatory controls Nícolas F. R. A. Prado (2): apps: lc-compliance: Fix source file ordering in meson.build apps: lc-compliance: Check that requests complete successfully .../capture.cpp} | 48 +++++---- .../{simple_capture.h => helpers/capture.h} | 14 +-- src/apps/lc-compliance/meson.build | 11 ++- .../{ => tests}/capture_test.cpp | 9 +- .../lc-compliance/tests/controls_test.cpp | 98 +++++++++++++++++++ 5 files changed, 146 insertions(+), 34 deletions(-) rename src/apps/lc-compliance/{simple_capture.cpp => helpers/capture.cpp} (76%) rename src/apps/lc-compliance/{simple_capture.h => helpers/capture.h} (76%) rename src/apps/lc-compliance/{ => tests}/capture_test.cpp (95%) create mode 100644 src/apps/lc-compliance/tests/controls_test.cpp --- 2.41.0