From patchwork Wed Dec 6 10:38:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 19284 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D38FFC322E for ; Wed, 6 Dec 2023 10:38:46 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 18E0561D9D; Wed, 6 Dec 2023 11:38:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1701859126; bh=a8Zw/4+NbTbF5XXV+2qeEPMqgWoKx8dki5sECtaaVsc=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=lOkCahhlBxM9QasyuqSE7y9BpxdPPpOQSFbBlhYCCXa7srhAquBKfunglZFp0iFyV Va22gneJ1jCPTBrmBFBSQbYVfxrrodXxwSb/9qDlXZtgVv3F0nqaxIlTR6B552sgKf y/IHqfq19a82Bhnr3Q8HQJg4oIDetow6yrRSiZAW6Goo3VifShYk4vBNHVjK+IH1TL 7AYpJd3Li5+l34CAYDlhldeLFoWmsj0fGB1ZnQzGHL3mdxjiZZ0JXiRzvtK7Gh/pz5 YFNI3LXFO9AQZdbXy88su1tDH1e+mZ9yVcOq7uTf84yMRX15Eezem8844cgADPg4je j1vKOVXzxrQ8A== Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D42AB61D9D for ; Wed, 6 Dec 2023 11:38:43 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="ZKmFAST7"; dkim-atps=neutral Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-333536432e0so522152f8f.3 for ; Wed, 06 Dec 2023 02:38:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1701859123; x=1702463923; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=V1yf7h1w9Bu/BdPvNIQqM2hAyWMVqlKEctf0e7DtcnI=; b=ZKmFAST75DlpvClrX4kUtiQnoVKLGSHxiwx1MXDNr79jxHH0yar2988ZWajQcPglmB MVloV7tk3nJ7IxSsKSaJquwAc92dACjOmG7wZIhw9Mlt6WvJBE3ntdGKxsaGRwB2m5S3 QysIs5ueTEFYneP8l0YdWdtHmSHCPhOA3CdyGV6GaWiqOgZpSUeYPsPNsBO/kWoeva0A wLI1D3E4IXchF3Ix9xTEuGLKtw8OWnIxSB0IH7b7uvjL1f854N9rpyFJ7Cmr6QXTDmDT PvaVJ4ErY2qEsuYXTyYCMx6rm0iQUf+WvkSj7/vqJqV8N8jXvRbeKxBFwD3gAYLbEn39 AC1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701859123; x=1702463923; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=V1yf7h1w9Bu/BdPvNIQqM2hAyWMVqlKEctf0e7DtcnI=; b=hiQOWifkZtDVr4BHkQQLrzExaY/bnoYj6d2lnogO3dN6FS344sUZVjI9WA0NMm1U/D CZYl5vBzolsSL79EYE7DQYfKBjaN58Wbb52gbAdMhVj/lUfmJTaxXA9g02V22kja7rE7 5tg9u1YknxLAPNGdQCr7lf2BmscboYrAb8o9oGACNwEJyxm39ZC10H/rqwEkCPCiNTAK 5uZyzmcsFytULYEQNwKdqvtQRhOPdQL0h9D7tfhdiubvSdDk3WrS1Pj/zESCl2w/SG+u yeg72XJkEiRciOuCMb7WZxjDwKDcd5Mma94vuETwl52oh5iTamK5jNTKz1vpvWWV+EbP CNBQ== X-Gm-Message-State: AOJu0Yyv91K4Lf3AjvBQG4vcfwxF3HxQ84b4tSBJZJgDjqtwA1n9i6kC 5ItUcNkJpuWIIW8ml7+6yjdDrxR0CmdkdMllVds= X-Google-Smtp-Source: AGHT+IGILkXI5x8OMdg3J7Na/S0yj245EU3dX28OWMvcYOSCVhMP7EYZMHAaE2tSOCFgDZX7CSr4Jg== X-Received: by 2002:a05:6000:b8c:b0:333:2fd2:6f59 with SMTP id dl12-20020a0560000b8c00b003332fd26f59mr394384wrb.99.1701859122839; Wed, 06 Dec 2023 02:38:42 -0800 (PST) Received: from localhost.localdomain ([194.233.231.115]) by smtp.gmail.com with ESMTPSA id w7-20020a5d6087000000b0033340937da6sm9733697wrt.95.2023.12.06.02.38.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 02:38:41 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Wed, 6 Dec 2023 10:38:37 +0000 Message-Id: <20231206103839.16607-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/2] IPA initial values for Raspberry Pi X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Plowman via libcamera-devel From: David Plowman Reply-To: David Plowman Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi Just a quick word to explain these patches seeing as no one is using them (yet). They're going to be used on the PiSP (Pi 5) platform where we have a particular problem in needing to program up the statistics blocks which are part of the Camera Front End. We have to do this before we start the camera, so there has been no chance to process any frames and discover suitable colour gains and black levels. Therefore these methods provide a way for the Pi 5 pipeline handler to apply sensible default values, so that the statistics for the first few frames (before those algorithms have actually run) are usable. The only values that we really need are black levels and plausible colour gains for this sensor. Thanks! David David Plowman (2): ipa: rpi: black_level: Add an initialValues method ipa: rpi: awb: Add an initialValues method src/ipa/rpi/controller/awb_algorithm.h | 1 + .../rpi/controller/black_level_algorithm.h | 23 +++++++++++++++++++ src/ipa/rpi/controller/rpi/awb.cpp | 6 +++++ src/ipa/rpi/controller/rpi/awb.h | 1 + src/ipa/rpi/controller/rpi/black_level.cpp | 10 +++++++- src/ipa/rpi/controller/rpi/black_level.h | 6 +++-- 6 files changed, 44 insertions(+), 3 deletions(-) create mode 100644 src/ipa/rpi/controller/black_level_algorithm.h