From patchwork Thu Nov 23 04:48:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 19227 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0C7BAC3220 for ; Thu, 23 Nov 2023 04:48:22 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 460E8629AF; Thu, 23 Nov 2023 05:48:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1700714901; bh=bJCCk5yBaYJa8Y3g27/Cqlwytm7KjhkbMjnmLC8K2tk=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=LCtDWKO55PKe6O38t+C4IiCxPnvwi+Rr0oe7JhfWM9SX55fgpfqSV/pTkr/PSmMUL E7odNu+WSxVjoKJ0XWcE33W1X8aLLD1xW73xLTzlzVdh7N6ZkTVlzLWBFIF/eTpaVU 31gO5lgVeMooaE8f6efFWN2Ea/gHLLsGahA0ofVXV9OQ991BQFKcL8rrhawd3uOvXH DzZ6WEIu8lIHoBRxih7aNyWY3tAaeS0YNt/WJEiVYFWPCUzV71o4A8iOu+/EbmrngD 6kdxaZswkPp3fqYcyjMqqZ4469VUlg/fCBRoHUCIHSNRJJm3gJ/NlK++5640PkZqqP afHbWD94n+r/w== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E4C8261DA6 for ; Thu, 23 Nov 2023 05:48:19 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Fmkqz9e0"; dkim-atps=neutral Received: from umang.jainideasonboard.com (unknown [103.251.226.72]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 04A17749; Thu, 23 Nov 2023 05:47:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1700714868; bh=bJCCk5yBaYJa8Y3g27/Cqlwytm7KjhkbMjnmLC8K2tk=; h=From:To:Cc:Subject:Date:From; b=Fmkqz9e09gvUAvOESQoSeZW4Swnm7W2Zmdtuq0gLudRLhCiaDKpdfwXg4iBVWbGGt cY2meGJrc08bL1WpgryKfBNWbI3iirdgDLqbaGquIgiZo9q/sQxiQ6/kOLPACYO4Je HhBnXOOnjVJ5J5TYT6YqyiL6x3xRRP6slK8/kM2s= To: libcamera-devel@lists.libcamera.org Date: Thu, 23 Nov 2023 10:18:09 +0530 Message-Id: <20231123044811.70703-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/2] gstreamer: Fix EOS clang build breakage X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Umang Jain via libcamera-devel From: Umang Jain Reply-To: Umang Jain Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The commit fd84180d7a09("gstreamer: Implement element EOS handling") introduced a compile breakage on clang: ../../src/gstreamer/gstlibcamerasrc.cpp:768:23: error: unused variable 'oldEvent' [-Werror,-Wunused-variable] g_autoptr(GstEvent) oldEvent = self->pending_eos.exchange(event); ^ Revert the patch and re-applied it with a clang pleasing fix. Jaslo Ziska (1): gstreamer: Implement element EOS handling Umang Jain (1): Revert "gstreamer: Implement element EOS handling" src/gstreamer/gstlibcamerasrc.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)