From patchwork Thu Oct 26 11:11:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 19184 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BD752BDCBD for ; Thu, 26 Oct 2023 11:11:38 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4401D62991; Thu, 26 Oct 2023 13:11:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1698318698; bh=d9lSMQsyB+u7Ex8IM/ikZV3kK6+AJburTBEm9DkEYKg=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=jGyQV7HuDLkcffqOE+BdREoE72/2sGUvxYGXtIPj2HgjMehtJCw59p+Qfrr4mxeC8 EP7PtBvL67RF85ogWOy2huXUF20RMf+8DaCKdAu1I6bVjrTyyLxAXGuCC+8vW9UqRx nSp39rG3O7kn4EP5nzBeForXtJIZ1ODpbEVc+5fWU/UtYteWE+kLNZ684+nCV0hF/L Xd56hNPZhgPxb2dVZAAqfMgcn5fLve3/GU+gd+3hNGE0F76BDpo8hPuk+FRMd5RfDT RAdYRlKMsAlgLh3WHIv6JqhNmoYZ23p1S7qQVx1zCXbkPYB4wsTsQH8QNzbdhss4lf NORdG7H/sX9xA== Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A941261DCC for ; Thu, 26 Oct 2023 13:11:36 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="D+0+6NWI"; dkim-atps=neutral Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-507a3b8b113so1078616e87.0 for ; Thu, 26 Oct 2023 04:11:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1698318695; x=1698923495; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8rrpYaosuszeJA7NepaeJnmlXnkrj/FNzHt4sxfJ2q0=; b=D+0+6NWI5tU382bPoUmyq+IeWiXCjDq/x59/6evINn/zLt/gMh/G+FkKQY5wyC+S2D jhB7lRsH/3UwAAI5oMPcMob7znygpC6sI5ayqAbunCCc2FtyfLA573ZZwuynnd+T56e6 qoZLoWG2+wnk27hEwQMbFhdMaZgT6XQbcnuVlPzvsIZy50KoAcmjyouG/Gx5l3ateRcu KP0pX4mrfMMv4VidLe0VlpTfhLcAwMQtVQY4JayX+S7jx3J8Gp3H1d9koJFUP7w/yXdD 39CRgnJMJtCBpgKwlbWqJhor51nNUL4OS/3yEOdYwUld4bGU9jTC896M7KTtOYACDy9H jrMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698318695; x=1698923495; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8rrpYaosuszeJA7NepaeJnmlXnkrj/FNzHt4sxfJ2q0=; b=vC+fx5dyBYx12p7aUJWpXU7yJkhHALhCFy254FYTCTlzHxWOBHjZqZFRJ2E+XVOZu2 HRW7AiRFhwDsVUyWwHE9r/wggY+mLpxYEOiRMXEDcjt4dRZGHflV19fB+ENiWjOt8ANw bog/HF9gcYr0v8uS5ZiddRAommTpZE6/YyxO9y/pepfs+u0FLx+3QeHCZU1XSggs+NQd zP3TniBhu18R2ne5dgSUtS8J/IrUFc4sx3Un5pXXS/14uh3jpNmAMpMm/WgLc3pZyE9R vTRrUP5Jr7B+VB2hfoIar57MtQ4bDA2YT1yxRMBweoUSesXEGndq4VjFcDM1+Uts4Ams 09vA== X-Gm-Message-State: AOJu0YwY0eMz2MmjYU4m/unaZTzb9Lx+sfDrklKljSlNuT+ivNyk4o2R oEHVKyr95ZMiuthDP3C09KqD3xSkYYv3m0e/9LM= X-Google-Smtp-Source: AGHT+IGDSrQLZ3lUPn1QpjDRBeEfdRFwJXfakQ17sipshEgwJFZaaZgM6IG9zJWDinc33YUpbYFHhg== X-Received: by 2002:ac2:5304:0:b0:503:36cb:5436 with SMTP id c4-20020ac25304000000b0050336cb5436mr12098213lfh.9.1698318695316; Thu, 26 Oct 2023 04:11:35 -0700 (PDT) Received: from pi5-davidp.pitowers.org ([2a00:1098:3142:14:183e:6cc8:a436:a27c]) by smtp.gmail.com with ESMTPSA id d17-20020a5d6451000000b0032da022855fsm13960075wrw.111.2023.10.26.04.11.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 04:11:34 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Thu, 26 Oct 2023 12:11:30 +0100 Message-Id: <20231026111131.93825-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v5 0/1] HDR controls X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Plowman via libcamera-devel From: David Plowman Reply-To: David Plowman Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi Version 5 is mostly trying to be more specific about the descriptions, concentrating in the main on what the normal or default implementations might do (before anyone dives in and alters the behaviour). I have a few little niggles: * The night mode is still a bit vague. I don't have much of a feel for whether there is a reasonable default behaviour for this. I suppose we could just say that frames are labelled long/medium/short according to the implementation? * I've said vaguely that frames cycle between short/long or short/medium/long according to the implementation. Do we need to be signalling which category an implementation falls into? * There's no clear reason why HdrChannelNone exists. I do believe it is useful, not just for Pi users who might want to mess around and do unusual things, but also when switching exposures reliably from frame to frame proves difficult (because it is quite hard to do right). Thanks! David David Plowman (1): libcamera: controls: Add controls for HDR src/libcamera/control_ids.yaml | 87 ++++++++++++++++++++++++++++++++++ 1 file changed, 87 insertions(+)