From patchwork Tue Jul 25 08:55:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 18882 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 903CEBDB13 for ; Tue, 25 Jul 2023 08:56:11 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 91F7D628C3; Tue, 25 Jul 2023 10:56:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1690275370; bh=HxnLZ0pvFL1osMUrMwoRWDRFJEo9X9VZv81t3wpY5Vw=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=WqnrOZFHZWM3FsXlli4H8T/XxM5PWvbKMjlLAczx/gHE0Djpq9mtxagQtqg0MsSyu wZb+GD84/vHJ+nxUYMtaZY5HuCr+X0nlt3yBYN8Whw03kqTvgCePetV2vG3evmYQlG Efiegry/T97ct2zBLSidBEDvmO5Co1ZXF/VDyTTU33JM2dVgrYhyxkin51iddwcfcj pvLzx39eLgqyd/KCmpOJUhVuAgOWS6ShZXIF/Bc1fTF8qnk1rqIzxFd0jobMDGZ+Vu IMQlqrF6uinzP42Bz/L/gxB35JU6z/txRNf7fvYKjHG2IWqAdzJC6CrDx6a2YhrOr0 gJomNBYNSeskg== Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 83BC1600F7 for ; Tue, 25 Jul 2023 10:56:08 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="NDXeNblw"; dkim-atps=neutral Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-31765aee31bso1152221f8f.1 for ; Tue, 25 Jul 2023 01:56:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1690275368; x=1690880168; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qWBkQTdFHAEdU6nmosouLbrPgiH9K9J7Awo9cMnRgsE=; b=NDXeNblwuqkzwe37BMGnljcT+BCcTobPjIDqyhrUXC3YNXbxm3vQ/Vu12oMHslILLR LOAQYPKe69ml1M0SbYycMRRDbTF+Wn3IMKI2Z3Gc1lRs6IzacTBr8GN6o+cIPPNDycvb bBMfsonvbx1P7V3+C7kE6ex36URI4OEIhzuaQxfSYMlJsxZJXwxpcyGrAhHMLXeSoqgL eFH9JnAjLj9y8UEauKQxk4mOF95/QbsRxtJQ8MABC2AaGlV0OP19W4YfvcJyA2MbUn8T z9DM3kopM3SRtBgPi+n+ptZrrLdDtSV5iAA2q3uxutDInjxNHd+j8UhAPKyeoS9RHQ8D qvdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690275368; x=1690880168; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qWBkQTdFHAEdU6nmosouLbrPgiH9K9J7Awo9cMnRgsE=; b=HnJveOnlA1hEI9Yyo+PU5DrKPVwZLculNfVCs5NFsWTJvb6F2K10BkKtOTQZRnLyaQ UdCRHMhikABhCIrT2sh/grw5HYZ8DIOZmk36IreKuhs5qcD0FIKnOGayVdlJielhqLOs L31EBshFHQpINCIyL7BxvU0+X9ptaTjyb2Xk90dkRGg8qw3s0oZe7XIKsYOB3g1vN9le 7k++fL/+1nNHPlWEgt0BDNDEq3ae4c6pZ1ViZOKk4pf0V+pCoiEm9zh6/cwGJWSFzGjK AkLq4NAyKq8Xcv9Lk4EZNUdtzemMa0KjnxHkldTSUspxCs92keW3//rzu7ONoG9c8K+x eStg== X-Gm-Message-State: ABy/qLapnCRjDH2ZRMKO55QZvRH25MSeolZsZ9GAF4BhfCHM2NlAh9Cs +VwGwj6eNtSXyG4x0AOwvEcRAccumQH23SrU8KkNlQ== X-Google-Smtp-Source: APBJJlGvuin5EkpM16fWfh4sRVXJ3CTfLZmWGqN/wIzu6zKTib71FRyw/6LeMy+MGwebUXFPOfBRew== X-Received: by 2002:adf:f488:0:b0:314:311d:1b9 with SMTP id l8-20020adff488000000b00314311d01b9mr9019472wro.47.1690275367783; Tue, 25 Jul 2023 01:56:07 -0700 (PDT) Received: from localhost.localdomain ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id l7-20020adfe587000000b0030c4d8930b1sm1951225wrm.91.2023.07.25.01.56.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jul 2023 01:56:07 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Tue, 25 Jul 2023 09:55:36 +0100 Message-Id: <20230725085540.24863-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/4] Raspberry Pi: External buffer handling X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Naushir Patuck via libcamera-devel From: Naushir Patuck Reply-To: Naushir Patuck Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, Very minor changes in v2 to address Jacopo's comments: 1) Remove the "count" test in patch 1/4. 2) Remove the CameraData::handleExternalBuffer() declaration in patch 2/4. 3) Fix RPi::Stream() constructor for initial id value in patch 4/4. Regards, Naush Naushir Patuck (4): pipeline: rpi: Increase buffer import count to 32 pipeline: rpi: Remove additional external dma buf handling logic pipeline: rpi: Rename RPi::Stream::setExternalBuffer() pipeline: rpi: Simplify buffer id generation .../pipeline/rpi/common/pipeline_base.cpp | 18 +------ .../pipeline/rpi/common/pipeline_base.h | 1 - .../pipeline/rpi/common/rpi_stream.cpp | 53 +++++-------------- .../pipeline/rpi/common/rpi_stream.h | 48 ++--------------- 4 files changed, 17 insertions(+), 103 deletions(-)