From patchwork Fri Jul 21 09:37:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 18857 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 22535BDC71 for ; Fri, 21 Jul 2023 09:38:00 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 50A21628BC; Fri, 21 Jul 2023 11:37:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1689932279; bh=RSW6gk3AIvWofA0faXzi8+Bzk+EfoLzcsT7LMWuNVz8=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=RWl2P2V4alnJ//8XcvUAnqz3i9V3fnQXDzhLs9Iv+V5IHM0RimfnhHbKtk8Uh1NJo PDvkFiKkmHH60AyNNMOZhnLyeWPKmBtQlOEXdpRK3nSfYjgdaql5GNKoBQUQXEIB90 NaWr47CY8VoRkpTuxJRIr07o88S9agqiFU+2U9LQyCsWvEfY0hg39t5P2JIJxsN90X zeGWJRFHqLod6hsPMye7X+gqx4ZhIuZzjHbX/oyK3EflF7aLsAc9MKczezs2h77BU4 RM0Ako3tA43DXjMcUZFtSySJOPKJhVPIoiIX8EF82qDLcJm8Wi/kQHBhv9UUgj0AcM 2h9X/nKbPdeZQ== Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CF72A61E29 for ; Fri, 21 Jul 2023 11:37:57 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="O2MS3vad"; dkim-atps=neutral Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-3144098df56so1477673f8f.2 for ; Fri, 21 Jul 2023 02:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1689932277; x=1690537077; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lEUhoKI+RPkekK/+og2fwE1pOC/C3z1xCmEFOaFrGVk=; b=O2MS3vadTtJDyk1F8sO3DyC8oVopj16QBrcS9Ux3KyeVscv5l3bCyGUsemoSiSYGW+ 3HxNWMimQLdytmRgrNhv7vZJssdP01a4SiA7Du32JfwdQizI2bzKunrII+PnZ5M4bzWT vHxtOeo3NGcdTQ1P1vJJDyupngQcvP8T/lhkpcKdfj0rIosAUksmSd1hgudZ/gGe8dZA dnu8SalVk5ZTMkMW3UNjEgVeKvkhbF9RHt1YEs1JQuKa7PhTfNsnQKG7hWVnQyNoZOhU HW6fqoeiVEQto0YUdpBUgyAgkKxVJvp0wtmeIk+nLUrhPxqZCoLZsEHU81In2mT6Fthm mWuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689932277; x=1690537077; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lEUhoKI+RPkekK/+og2fwE1pOC/C3z1xCmEFOaFrGVk=; b=O9hYctEl0ocfst0J4ug1gqxO1ghdlMgIf6BfNM/GBG7Pz6ElkBeDarskZzOHk+WgJd XD20Z8kZRZ47kmeYaSy0esUXouun2bY6LRWCGr1AZ8xhWd5t3bQU4MhAtCF90t3AQSf/ 5+boamYXziGYKEgiHvtvZX30h4b5Im9m/O4SrQ7vcbMp61OPx5mNGdqH66xEriCUO45u izjE0PfVXNNFWsBVJ6OiU4raNAOZ8rzo5dCdH1xu0q5mjEO916cW2V63X/sqShtCNAL+ 4KyjZXliyHtc7mKk+OUYsS2gDGq+h4X1RALBU4ATqmKGYM6twSRYIM+e0LKsQBt+ecaZ FFDA== X-Gm-Message-State: ABy/qLbVtw+Mi0ZoZ3FiT4xWOuCyzyFfqAtuea1u1PJb0lagFMV4wmEO YCn/nkl3oqY7vhDkOJZIpyOcQHElUgcCySuIqHJhJQ== X-Google-Smtp-Source: APBJJlErqk6iJPeoNNYA3KF6g2d68Jd+L7JWxWeBhyvWUK21otS8xEzhrvgIatCfg6B3jgWcKkvyew== X-Received: by 2002:a5d:638b:0:b0:314:1e73:d15d with SMTP id p11-20020a5d638b000000b003141e73d15dmr1115292wru.11.1689932276902; Fri, 21 Jul 2023 02:37:56 -0700 (PDT) Received: from localhost.localdomain ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id n12-20020a5d6b8c000000b003143c6e09ccsm3674663wrx.16.2023.07.21.02.37.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 02:37:56 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Fri, 21 Jul 2023 10:37:55 +0100 Message-Id: <20230721093759.27700-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v1 0/4] Raspberry Pi: External buffer handling X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Naushir Patuck via libcamera-devel From: Naushir Patuck Reply-To: Naushir Patuck Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, This small patch series simplifies handling of application/externally allocated buffers for use in requests. For the mode part, these patches remove code that was trying to distinguish between the two different allocation types, and this is not actually necessary any more. This has been tested on a fork of libcamera-apps where buffers are allocated through the dma heap at the application level and passed into requests. This fork is available at: https://github.com/raspberrypi/libcamera-apps/tree/dma_heap. Once these chanages have been merged libcamera-apps and picamera2 will eventually switch to use dma heap allocations instead of V4L2 allocations. Thanks, Naush Naushir Patuck (4): pipeline: rpi: Increase buffer import count to 32 pipeline: rpi: Remove additional external dma buf handling logic pipeline: rpi: Rename RPi::Stream::setExternalBuffer() pipeline: rpi: Simplify buffer id generation .../pipeline/rpi/common/pipeline_base.cpp | 18 +----- .../pipeline/rpi/common/rpi_stream.cpp | 55 +++++-------------- .../pipeline/rpi/common/rpi_stream.h | 46 +--------------- 3 files changed, 17 insertions(+), 102 deletions(-)