From patchwork Tue Jul 18 14:42:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 18852 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 9321ABDB1C for ; Tue, 18 Jul 2023 14:43:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B1C09628C1; Tue, 18 Jul 2023 16:43:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1689691386; bh=zNbX3A7gZ37/bYtRLZpfnApfvVWnHjv2FyKup0e6Cmk=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=HMojW96ybqPn+qfsro1dLhgdOGrSJtkN6VyMpx7/YaWbdTWTav5BJtcbCgVR9y+Ho OS5yosJOp2BTKhdmWneTOqpJOs8PUjVZS9DvMdt7SZzhE5kOpvrUMoXlP9EBOdcoHq 6ft3JJTefRPiB71x5tUBg8mVfcTy5xlxOut1dyn1CQ1yzX9btPzlxztmvVciwCw56J HfWR8fHMRAVfmI80yrdNIlIRArmXCxNNf3QmnrRF8j1Z1XeJYKi9H6tg33Bjrn9RFO 5Dpbx0sB1iLsdnBmKvng0gXMvkGUf+mZC9vmUAyzMdHTDxTqXfRjLknyidWviZs7Lx qzNA4K27s58ug== Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A24F861E2B for ; Tue, 18 Jul 2023 16:43:05 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="Fd/x33k1"; dkim-atps=neutral Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-3fb4146e8deso60441315e9.0 for ; Tue, 18 Jul 2023 07:43:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1689691385; x=1692283385; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WHLtE40cZNFU8gXFfzMM9XDoj28Ln7WCsoUfdCSDag8=; b=Fd/x33k1wgrhNUppXeuaoFKJKA0fJF/qmeqcwInzpoZ0FlegIG2y/4hhftny9IjrpW CNi25ciRLbMc0kz8yGdfwdZRXQjeG1COXa+QV3ghuRSJ9hm7gd9tnn2bqSfeycHnd5KH VC8mCYN84s4eiRnhe1N3c7gzyX+81FLSTMOJT9zdt/wsLlm57/7j/x3olvNTZ5vjOJuN 7YpUZBG0BMe3iQHwjAZjugyz4rPOL4cIlecE9lNUAUU+uwtv4ATBQj/YnGfpkS0DcDzI DAvMyxJ1xqzSxPsPeDCIwVxre+NkngVTTEwobRb0mW3ikGHRSQJ5Zi5XEHC9GiQ9Df8G TN1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689691385; x=1692283385; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WHLtE40cZNFU8gXFfzMM9XDoj28Ln7WCsoUfdCSDag8=; b=Ypd1FIaRvdhC0s3gudOYg37WeNJFSl78UHNXuitncQ0VlbPDREhL1PCYVIq7FKcO6O HrlaMiboyw44SVxCOtMWSNZ64glkd/24oH0J3d7zH0yTU1M8sdmQbo8NM8pjDnk8oSJV O2c8twwVqlsZn0Euq+i6qsFybNpwIG0UwKiwk43xMKfgL4nY8Dqj59QXj4Vv7oQpD48v QJqdZEQxoko+JtoaWTPoZkWLZzJ5e/UpboZj4Ta71gHDo+Wo51h+XhQhMNrNDJ1rADUB JTlKGpT20/Tubzn+2EAf5KeI6rXA+7IIe/3eP1FvMkFOD6TuMQx0L+eR92PfKLXGokJz 2yDw== X-Gm-Message-State: ABy/qLZLNEiIc7lUp8rsH+8wgXn1c1anKKbeAJ3JnrMu3bUUzYXc2WnZ msi5xNGRsYHto3n51lVvR/SS1WQIbSP7AuQc6bc= X-Google-Smtp-Source: APBJJlH9q4JHZjwxzDWzssPQuDl2oP72yvR086aA+i/XRn4L1tCoxhZ1HbDyP4Mnz2Bnaic+L8cnHA== X-Received: by 2002:a7b:cd96:0:b0:3fb:424b:ef6e with SMTP id y22-20020a7bcd96000000b003fb424bef6emr2284388wmj.23.1689691384768; Tue, 18 Jul 2023 07:43:04 -0700 (PDT) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:2bce:64d6:1a5c:49a2]) by smtp.gmail.com with ESMTPSA id 12-20020a05600c230c00b003f90b9b2c31sm10469686wmo.28.2023.07.18.07.43.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 07:43:04 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Tue, 18 Jul 2023 15:42:59 +0100 Message-Id: <20230718144301.3612-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v5 0/2] Add flicker avoidance controls X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Plowman via libcamera-devel From: David Plowman Reply-To: David Plowman Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi everyone Changes since v4: The FlickerCustom mode has been renamed to FlickerManual. The AeFlickerCustom control has been renamed to AeFlickerPeriod. There is a bit of documentation rewording (I hope some things are slightly clearer), and a couple of minor code tidies as was suggested. Thanks David David Plowman (2): libcamera: controls: Add controls for AEC/AGC flicker avoidance ipa: rpi: common: Handle AEC/AGC flicker controls src/ipa/rpi/common/ipa_base.cpp | 64 ++++++++++++++++++++++- src/ipa/rpi/common/ipa_base.h | 6 +++ src/libcamera/control_ids.yaml | 90 ++++++++++++++++++++++++++------- 3 files changed, 142 insertions(+), 18 deletions(-)